Skip to content

Commit 1ba8f21

Browse files
jiahaogadsonpleal
authored andcommitted
Use testWidgets instead of test to fix failures not surfacing on CI (flutter#3279)
1 parent a4048a6 commit 1ba8f21

File tree

24 files changed

+58
-24
lines changed

24 files changed

+58
-24
lines changed

packages/integration_test/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.9.3
2+
3+
* Update README to mention that only `testWidgets` is supported for declaring tests.
4+
15
## 0.9.2+2
26

37
* Broaden the constraint on vm_service.

packages/integration_test/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ Create a `integration_test/` directory for your package. In this directory,
1414
create a `<name>_test.dart`, using the following as a starting point to make
1515
assertions.
1616

17+
Note: You should only use `testWidgets` to declare your tests, or errors will not be reported correctly.
18+
1719
```dart
1820
import 'package:flutter_test/flutter_test.dart';
1921
import 'package:integration_test/integration_test.dart';

packages/integration_test/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: integration_test
22
description: Runs tests that use the flutter_test API as integration tests.
3-
version: 0.9.2+2
3+
version: 0.9.3
44
homepage: https://github.com/flutter/plugins/tree/master/packages/integration_test
55

66
environment:

packages/shared_preferences/shared_preferences/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.5.13
2+
3+
* Update integration test examples to use `testWidgets` instead of `test`.
4+
15
## 0.5.12+4
26

37
* Remove unused `test` dependency.

packages/shared_preferences/shared_preferences/example/integration_test/shared_preferences_test.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ void main() {
3333
preferences.clear();
3434
});
3535

36-
test('reading', () async {
36+
testWidgets('reading', (WidgetTester _) async {
3737
expect(preferences.get('String'), isNull);
3838
expect(preferences.get('bool'), isNull);
3939
expect(preferences.get('int'), isNull);
@@ -46,7 +46,7 @@ void main() {
4646
expect(preferences.getStringList('List'), isNull);
4747
});
4848

49-
test('writing', () async {
49+
testWidgets('writing', (WidgetTester _) async {
5050
await Future.wait(<Future<bool>>[
5151
preferences.setString('String', kTestValues2['flutter.String']),
5252
preferences.setBool('bool', kTestValues2['flutter.bool']),
@@ -61,7 +61,7 @@ void main() {
6161
expect(preferences.getStringList('List'), kTestValues2['flutter.List']);
6262
});
6363

64-
test('removing', () async {
64+
testWidgets('removing', (WidgetTester _) async {
6565
const String key = 'testKey';
6666
await preferences.setString(key, kTestValues['flutter.String']);
6767
await preferences.setBool(key, kTestValues['flutter.bool']);
@@ -72,7 +72,7 @@ void main() {
7272
expect(preferences.get('testKey'), isNull);
7373
});
7474

75-
test('clearing', () async {
75+
testWidgets('clearing', (WidgetTester _) async {
7676
await preferences.setString('String', kTestValues['flutter.String']);
7777
await preferences.setBool('bool', kTestValues['flutter.bool']);
7878
await preferences.setInt('int', kTestValues['flutter.int']);

packages/shared_preferences/shared_preferences/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ homepage: https://github.com/flutter/plugins/tree/master/packages/shared_prefere
55
# 0.5.y+z is compatible with 1.0.0, if you land a breaking change bump
66
# the version to 2.0.0.
77
# See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0
8-
version: 0.5.12+4
8+
version: 0.5.13
99

1010
flutter:
1111
plugin:

packages/shared_preferences/shared_preferences_linux/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.0.3
2+
3+
* Update integration test examples to use `testWidgets` instead of `test`.
4+
15
## 0.0.2+4
26

37
* Remove unused `test` dependency.

packages/shared_preferences/shared_preferences_linux/example/integration_test/shared_preferences_test.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ void main() {
3333
preferences.clear();
3434
});
3535

36-
test('reading', () async {
36+
testWidgets('reading', (WidgetTester _) async {
3737
expect(preferences.get('String'), isNull);
3838
expect(preferences.get('bool'), isNull);
3939
expect(preferences.get('int'), isNull);
@@ -46,7 +46,7 @@ void main() {
4646
expect(preferences.getStringList('List'), isNull);
4747
});
4848

49-
test('writing', () async {
49+
testWidgets('writing', (WidgetTester _) async {
5050
await Future.wait(<Future<bool>>[
5151
preferences.setString('String', kTestValues2['flutter.String']),
5252
preferences.setBool('bool', kTestValues2['flutter.bool']),
@@ -61,7 +61,7 @@ void main() {
6161
expect(preferences.getStringList('List'), kTestValues2['flutter.List']);
6262
});
6363

64-
test('removing', () async {
64+
testWidgets('removing', (WidgetTester _) async {
6565
const String key = 'testKey';
6666
await preferences.setString(key, kTestValues['flutter.String']);
6767
await preferences.setBool(key, kTestValues['flutter.bool']);
@@ -72,7 +72,7 @@ void main() {
7272
expect(preferences.get('testKey'), isNull);
7373
});
7474

75-
test('clearing', () async {
75+
testWidgets('clearing', (WidgetTester _) async {
7676
await preferences.setString('String', kTestValues['flutter.String']);
7777
await preferences.setBool('bool', kTestValues['flutter.bool']);
7878
await preferences.setInt('int', kTestValues['flutter.int']);

packages/shared_preferences/shared_preferences_linux/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: shared_preferences_linux
22
description: Linux implementation of the shared_preferences plugin
3-
version: 0.0.2+4
3+
version: 0.0.3
44
homepage: https://github.com/flutter/plugins/tree/master/packages/shared_preferences/shared_preferences_linux
55

66
flutter:

packages/shared_preferences/shared_preferences_windows/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.0.2
2+
3+
* Update integration test examples to use `testWidgets` instead of `test`.
4+
15
## 0.0.1+3
26

37
* Remove unused `test` dependency.

0 commit comments

Comments
 (0)