Skip to content

Commit bc89655

Browse files
authored
make_release: do not annotate boolean switches in public API (#635)
related to - nushell/nushell#10456 - nushell/nushell.github.io#1071 ## description after the changes on boolean switches from nushell/nushell#10456, we need to not annotate then with `: bool` when part of a public API. this PR is required for nushell/nushell.github.io#1071 to move forward.
1 parent 907612c commit bc89655

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

make_release/bump-version.nu

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use std log
33

44
# bump the minor or patch version of the Nushell project
55
def main [
6-
--patch: bool # update the minor version instead of the minor
6+
--patch # update the minor version instead of the minor
77
]: nothing -> nothing {
88
let version = open Cargo.toml
99
| get package.version

make_release/nu_release.nu

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use std log
22

33
def publish [
44
crate: path # the path to the crate to publish.
5-
--no-verify: bool # don’t verify the contents by building them. Can be useful for crates with a `build.rs`.
5+
--no-verify # don’t verify the contents by building them. Can be useful for crates with a `build.rs`.
66
] {
77
cd $crate
88

make_release/release-note/list-merged-prs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ def main [
1313
repo: string # the name of the repo, e.g. `nushell/nushell`
1414
date?: datetime # the date of the last release (default to 4 weeks ago, excluded)
1515
--label: string # the label to filter the PRs by, e.g. `good-first-issue`
16-
--pretty: bool # pretty-print for the MarkDown release not
17-
--no-author: bool # do not group the contributions by author
16+
--pretty # pretty-print for the MarkDown release not
17+
--no-author # do not group the contributions by author
1818
] {
1919
let date = $date | default ((date now) - 4wk) | format date "%Y-%m-%d"
2020

0 commit comments

Comments
 (0)