Skip to content

fix: update branch_cache on get_branch() call #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shadmansaleh merged 2 commits into from
Oct 15, 2025
Merged

fix: update branch_cache on get_branch() call #1441

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c50a54
fix: update branch_cache on get_branch() call
rnxden Jul 5, 2025
ea61e46
fix: restore branch_cache update on update_branch() call
rnxden Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: update branch_cache on get_branch() call 
Update branch_cache on get_branch() call rather than on update_branch()
call to properly cache branches for all opened buffers, instead of only
the first buffer.

Fixes #1440
  • Loading branch information
@rnxden
rnxden committed Jul 5, 2025
commit 7c50a54660147c4aa341d9a393e5b634eb20c74a
3 changes: 2 additions & 1 deletion lua/lualine/components/branch/git_branch.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ local function update_branch()
-- set to '' when git dir was not found
current_git_branch = ''
end
branch_cache[vim.api.nvim_get_current_buf()] = current_git_branch
end

---updates the current value of current_git_branch and sets up file watch on HEAD file if value changed
Expand Down Expand Up @@ -150,6 +149,8 @@ function M.get_branch(bufnr)
end
if bufnr then
return branch_cache[bufnr] or ''
else
branch_cache[vim.api.nvim_get_current_buf()] = current_git_branch
end
return current_git_branch
end
Expand Down
Loading