Skip to content

Conversation

@wolfy1339
Copy link
Member

BREAKING CHANGE: Output a single ESM bundle

BREAKING CHANGE: Output a single ESM bundle
@wolfy1339 wolfy1339 added Type: Feature New feature or request Type: Breaking change Used to note any change that requires a major version bump labels Feb 23, 2024
@github-actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member Author

The types for the Fetch API don't allow headers to be passed as numbers, only as string. The docs also mention this https://developer.mozilla.org/en-US/docs/Web/API/Headers/Headers#init

I added a conversion since we accept numbers

@wolfy1339
Copy link
Member Author

There's some funkyness going on with fetch-mock... It's complaining about "Unmatched GET"/ "No fallback response defined for GET to [..]"

This fixes the tests, as we are expecting an Object in the fetch-mock matcher functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants