Skip to content

Commit 8fd8593

Browse files
committed
[BBGO-92] support Django 2.0
1 parent cd9cd01 commit 8fd8593

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+612
-387
lines changed

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.1.215
1+
1.1.216

accounts/migrations/0001_initial.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class Migration(migrations.Migration):
3838
('alarm_full', models.BooleanField(default=True)),
3939
('portrait', models.ImageField(blank=True, upload_to=b'portrait/%Y-%m-%d/', validators=[accounts.models.img_validator])),
4040
('signature', models.TextField(blank=True)),
41-
('user', models.OneToOneField(to=settings.AUTH_USER_MODEL)),
41+
('user', models.OneToOneField(to=settings.AUTH_USER_MODEL, on_delete=models.CASCADE)),
4242
],
4343
),
4444
]

accounts/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def img_validator(attached):
2222
class Profile(models.Model):
2323
"""User model extension"""
2424

25-
user = models.OneToOneField(User)
25+
user = models.OneToOneField(User, on_delete=models.CASCADE)
2626
point = models.IntegerField(default=1)
2727
last_article_at = models.DateTimeField(auto_now_add=True)
2828
last_reply_at = models.DateTimeField(auto_now_add=True)

accounts/views.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
from django.contrib.auth.models import User
1616
from django.core.mail import send_mail
1717
from django.core.signing import TimestampSigner
18-
from django.core.urlresolvers import reverse_lazy
1918
from django.db.models import Q
2019
from django.shortcuts import get_object_or_404, redirect, render
20+
from django.urls import reverse_lazy
2121
from django.utils.translation import ugettext as _
2222

2323
from teams.table import TeamTable
@@ -53,7 +53,7 @@ def setting(request):
5353
msg = _('Form validation Failure')
5454

5555
elif request.method == "GET":
56-
if request.user.is_authenticated():
56+
if request.user.is_authenticated:
5757
msg = ""
5858
settingform = SettingForm(instance=request.user.profile)
5959
else:
@@ -118,7 +118,7 @@ def edit_user_info(request):
118118
else:
119119
msg = _('Form validation Failure')
120120
elif request.method == "GET":
121-
if request.user.is_authenticated():
121+
if request.user.is_authenticated:
122122
msg = ""
123123
infoform = UserInfoForm(instance=profile)
124124
else:
@@ -188,11 +188,11 @@ def scrap_list(request, page=0):
188188
continue
189189

190190
index_total = int(ceil(float(total) / list_count))
191-
index_begin = (current_page / 10) * 10 + 1
191+
index_begin = int(current_page / 10) * 10 + 1
192192
index_end = mindex_end = index_total
193193
if index_end - index_begin >= 10:
194194
index_end = index_begin + 9
195-
mindex_begin = (current_page / 5) * 5 + 1
195+
mindex_begin = int(current_page / 5) * 5 + 1
196196
if mindex_end - mindex_begin >= 5:
197197
mindex_end = mindex_begin + 4
198198

@@ -327,7 +327,7 @@ def show_deactivate_account(request):
327327
@login_required
328328
def deactivate_account(request):
329329
"""Deactivate account"""
330-
if request.user.is_authenticated():
330+
if request.user.is_authenticated:
331331
request.user.is_active = False
332332
if request.user.is_staff:
333333
request.user.is_staff = False
@@ -380,11 +380,11 @@ def dashboard_user(request, condition='recent', page=1):
380380
users = User.objects.order_by(order)[start_at:end_at]
381381

382382
index_total = int(ceil(float(total) / list_count))
383-
index_begin = (current_page / 10) * 10 + 1
383+
index_begin = int(current_page / 10) * 10 + 1
384384
index_end = mindex_end = index_total
385385
if index_end - index_begin >= 10:
386386
index_end = index_begin + 9
387-
mindex_begin = (current_page / 5) * 5 + 1
387+
mindex_begin = int(current_page / 5) * 5 + 1
388388
if mindex_end - mindex_begin >= 5:
389389
mindex_end = mindex_begin + 4
390390

aliases/admin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33

44
from django.contrib import admin
55

6-
from models import Alias
6+
from .models import Alias
77

88
admin.site.register(Alias)

aliases/migrations/0001_initial.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class Migration(migrations.Migration):
2020
('url', models.URLField(max_length=255)),
2121
('created_at', models.DateTimeField(auto_now_add=True)),
2222
('clicks', models.IntegerField(default=0)),
23-
('user', models.ForeignKey(to=settings.AUTH_USER_MODEL)),
23+
('user', models.ForeignKey(to=settings.AUTH_USER_MODEL, on_delete=models.CASCADE)),
2424
],
2525
),
2626
]

aliases/models.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
class Alias(models.Model):
99
"""Alias of aliases"""
1010

11-
user = models.ForeignKey(settings.AUTH_USER_MODEL)
11+
user = models.ForeignKey(
12+
settings.AUTH_USER_MODEL, on_delete=models.CASCADE)
1213
name = models.CharField(max_length=32)
1314
url = models.URLField(max_length=255)
1415
created_at = models.DateTimeField(auto_now_add=True)

bbgo/settings.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
)
5353
THIRD_PARTY_APPS = (
5454
'rosetta',
55-
'jsi18ncache',
55+
'statici18n',
5656
)
5757
EDITOR_APPS = (
5858
'django_summernote',
@@ -71,13 +71,12 @@
7171
)
7272
INSTALLED_APPS = DJANGO_APPS + THIRD_PARTY_APPS + EDITOR_APPS + LOCAL_APPS
7373

74-
MIDDLEWARE_CLASSES = (
74+
MIDDLEWARE = (
7575
'django.middleware.security.SecurityMiddleware',
7676
'django.contrib.sessions.middleware.SessionMiddleware',
7777
'django.middleware.common.CommonMiddleware',
7878
'django.middleware.csrf.CsrfViewMiddleware',
7979
'django.contrib.auth.middleware.AuthenticationMiddleware',
80-
'django.contrib.auth.middleware.SessionAuthenticationMiddleware',
8180
'django.contrib.messages.middleware.MessageMiddleware',
8281
'django.middleware.clickjacking.XFrameOptionsMiddleware',
8382
)
@@ -201,7 +200,7 @@
201200

202201

203202
# Internationalization
204-
# https://docs.djangoproject.com/en/1.8/topics/i18n/
203+
# https://docs.djangoproject.com/en/1.11/topics/i18n/
205204

206205
# LANGUAGE_CODE = 'en-us'
207206
LANGUAGE_CODE = 'ko-KR'
@@ -219,9 +218,11 @@
219218
# https://docs.djangoproject.com/en/1.11/howto/static-files/
220219

221220
STATIC_URL = '/static/'
221+
STATIC_DIR = os.path.join(BASE_DIR, 'static')
222222
STATICFILES_DIRS = (
223-
os.path.join(BASE_DIR, 'static'),
223+
STATIC_DIR,
224224
)
225+
STATICI18N_OUTPUT_DIR = os.path.join(STATIC_DIR, 'jsi18n')
225226

226227
MEDIA_URL = '/upload/'
227228
MEDIA_ROOT = os.path.join(BASE_DIR, 'upload')

bbgo/urls.py

Lines changed: 18 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -13,45 +13,35 @@
1313
1. Import the include() function: from django.conf.urls import url, include
1414
2. Add a URL to urlpatterns: url(r'^blog/', include('blog.urls'))
1515
"""
16+
import django
1617
from django.conf import settings
1718
from django.conf.urls import include, url
1819
from django.conf.urls.static import static
1920
from django.contrib import admin
20-
from django.views.i18n import javascript_catalog
21-
22-
from jsi18ncache.views import javascript_catalog_cache
23-
24-
js_info_dict = {
25-
'packages': ('',),
26-
}
2721

2822
urlpatterns = [
29-
url(r'^admin/', include(admin.site.urls)),
30-
url(
31-
r'^jsi18n-debug/$',
32-
javascript_catalog,
33-
js_info_dict,
34-
),
35-
url(
36-
r'^.*/jsi18n/$',
37-
javascript_catalog_cache,
38-
js_info_dict,
39-
),
4023
url(r'^', include('django.contrib.auth.urls')),
4124
url(r'^', include('portal.urls')),
42-
url(r'^accounts/', include('accounts.urls', namespace='accounts')),
43-
url(r'^msgs/', include('msgs.urls', namespace='msgs')),
44-
url(r'^blogs/', include('blogs.urls', namespace='blogs')),
45-
url(r'^boards/', include('boards.urls', namespace='boards')),
46-
url(r'^teams/', include('teams.urls', namespace='teams')),
47-
url(r'^spams/', include('spams.urls', namespace='spams')),
48-
url(r'^api/', include('core.apiurls', namespace='api')),
49-
url(r'^vaults/', include('vaults.urls', namespace='vaults')),
50-
url(r'^recipes/', include('recipes.urls', namespace='recipes')),
51-
url(r'^a/', include('aliases.urls', namespace='aliases')),
25+
url(r'^accounts/', include(('accounts.urls', 'accounts'), namespace='accounts')),
26+
url(r'^msgs/', include(('msgs.urls', 'msgs'), namespace='msgs')),
27+
url(r'^blogs/', include(('blogs.urls', 'blogs'), namespace='blogs')),
28+
url(r'^boards/', include(('boards.urls', 'boards'), namespace='boards')),
29+
url(r'^teams/', include(('teams.urls', 'teams'), namespace='teams')),
30+
url(r'^spams/', include(('spams.urls', 'spams'), namespace='spams')),
31+
url(r'^api/', include(('core.apiurls', 'api'), namespace='api')),
32+
url(r'^vaults/', include(('vaults.urls', 'vaults'), namespace='vaults')),
33+
url(r'^recipes/', include(
34+
('recipes.urls', 'recipes'), namespace='recipes')),
35+
url(r'^a/', include(('aliases.urls', 'aliases'), namespace='aliases')),
5236
] + static(settings.MEDIA_URL, document_root=settings.MEDIA_ROOT)
5337

5438
if 'django_summernote' in settings.INSTALLED_APPS:
5539
urlpatterns.append(url(r'^summernote/', include('django_summernote.urls')))
5640
if 'rosetta' in settings.INSTALLED_APPS:
5741
urlpatterns.append(url(r'^trans/', include('rosetta.urls')))
42+
43+
if django.VERSION >= (2, 0):
44+
from django.urls import path
45+
urlpatterns.append(path('admin/', admin.site.urls))
46+
else:
47+
urlpatterns.append(url('admin/', include(admin.site.urls)))

blogs/admin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
from django.contrib import admin
55

6-
from models import Blog, Comment
6+
from .models import Blog, Comment
77

88
admin.site.register(Blog)
99
admin.site.register(Comment)

0 commit comments

Comments
 (0)