Removed unused let/const and adapted some logics to ES6

Author: Wellington Mafra

index.js

@@ -1,2 +1 @@
-import signalr from './src';
-export default signalr;
+export signalr from './src';

src/ajax.js

@@ -1,14 +1,14 @@
-export default function(options, data) {
-  var request = new XMLHttpRequest();
-  request.onreadystatechange = (e) => {
+export default (options) => {
+  const request = new XMLHttpRequest();
+  request.onreadystatechange = () => {
     if (request.readyState !== 4) {
       return;
     }
 
-    if (request.status === 200 && !request._hasError) {
-      options.success && options.success(JSON.parse(request.responseText));
-    } else {
-      options.error && options.error(request, request._response);
+    if (request.status === 200 && !request._hasError && options.success) {
+      options.success(JSON.parse(request.responseText));
+    } else if (options.error) {
+       options.error(request, request._response);
     }
   };
 
@@ -17,10 +17,8 @@ export default function(options, data) {
 
   request.send(options.data.data && `data=${options.data.data}`);
 
-//  request.abort("__Negotiate Aborted__");
-  
   return {
-    abort: function(reason) {
+    abort: (reason) => {
       return request.abort(reason);
     }
   };

src/bridge.js

@@ -1,19 +1,19 @@
 //Arrange new state
-let oldDocument = window.document;
-let oldReadyState = window.document && window.document.readyState;
-let oldUserAgent = window.navigator.userAgent;
+const oldDocument = window.document;
+const oldReadyState = window.document && window.document.readyState;
+
 window.document = {
   readyState: 'complete'
 };
 window.addEventListener = () => {};
-window.navigator.userAgent = "react-native";
+window.navigator.userAgent = 'react-native';
 
 //Act
 window.jQuery = require('./signalr-jquery-polyfill.js');
 require('ms-signalr-client');
 
 //Restore old state
-let hubConnection = window.jQuery.hubConnection;
+const hubConnection = window.jQuery.hubConnection;
 window.jQuery = undefined;
 window.document = oldDocument;
 
@@ -22,19 +22,19 @@ if (oldReadyState) {
 }
 
 module.exports = {
-  hubConnection: (serverUrl, logger) => {
+  hubConnection: (serverUrl) => {
     const protocol = serverUrl.split('//')[0];
     const host = serverUrl.split('//')[1];
     window.location = {
-      protocol: protocol,
-      host: host
+      protocol,
+      host
     };
     window.document = {
-      createElement: function() {
+      createElement: () => {
         return {
-          protocol: protocol,
-          host: host
-        }
+          protocol,
+          host
+        };
       }
     };
     return hubConnection(serverUrl);

src/index.js

@@ -1,43 +1,39 @@
 let signalRHubConnectionFunc;
-let oldLogger = window.console.debug;
 
 if (!window.addEventListener) {
   window.addEventListener = window.addEventListener = () => {};
 }
-window.navigator.userAgent = "react-native";
+window.navigator.userAgent = 'react-native';
 window.jQuery = require('./signalr-jquery-polyfill.js');
-  
-module.exports = { 
+
+module.exports = {
   setLogger: (logger) => {
     if (window.console && window.console.debug) {
       window.console.debug("OVERWRITING CONSOLE.DEBUG in react-native-signalr");
-    } else {
-      if (!window.console) {
+    } else if (!window.console) {
         window.console = {};
       }
     }
     window.console.debug = logger;
   },
   hubConnection: (serverUrl, options) => {
-    window.document = window.document || {
-      readyState: 'complete'
-    };
+    window.document = window.document || { readyState: 'complete' };
     if (!signalRHubConnectionFunc) {
       require('ms-signalr-client');
       signalRHubConnectionFunc = window.jQuery.hubConnection;
     }
     const protocol = serverUrl.split('//')[0];
     const host = serverUrl.split('//')[1];
     window.location = {
-      protocol: protocol,
-      host: host
+      protocol,
+      host
     };
     window.document = {
-      createElement: function() {
+      createElement: () => {
         return {
-          protocol: protocol,
-          host: host
-        }
+          protocol,
+          host
+        };
       }
     };
 

src/jquery-function.js

@@ -1,43 +1,44 @@
-export default function(subject) {
-  let events = subject.events || {};
+export default (subject) => {
+  const events = subject.events || {};
 
-  if (subject && subject === subject.window)
+  if (subject && subject === subject.window) {
     return {
       0: subject,
       load: (handler) => subject.addEventListener('load', handler, false),
       bind: (event, handler) => subject.addEventListener(event, handler, false),
       unbind: (event, handler) => subject.removeEventListener(event, handler, false)
-    }
+    };
+  }
 
   return {
     0: subject,
-
     unbind(event, handler) {
       let handlers = events[event] || [];
 
       if (handler) {
-        let idx = handlers.indexOf(handler);
-        if (idx !== -1) handlers.splice(idx, 1)
-      } else handlers = []
+        const idx = handlers.indexOf(handler);
+        if (idx !== -1) {
+          handlers.splice(idx, 1);
+        }
+      } else {
+        handlers = [];
+      }
 
-      events[event] = handlers
+      events[event] = handlers;
       subject.events = events;
-
     },
     bind(event, handler) {
-      let current = events[event] || [];
+      const current = events[event] || [];
       events[event] = current.concat(handler)
       subject.events = events;
     },
     triggerHandler(event, args) {
-      let handlers = events[event] || [];
+      const handlers = events[event] || [];
       handlers.forEach(fn => {
-        if(args === undefined) {
-          args = {
-            type: event
-          };
+        if (args === undefined) {
+          args = { type: event };
         }
-        if(!Array.isArray(args)) {
+        if (!Array.isArray(args)) {
           args = [args];
         }
         if (args && args[0] && args[0].type === undefined) {
@@ -48,8 +49,8 @@ export default function(subject) {
           args = args || [];
         }
 
-        fn.apply(this, args)
-      })
+        fn.apply(this, args);
+      });
     }
-  }
+  };
 };

src/signalr-jquery-polyfill.js

@@ -1,17 +1,19 @@
-import jqueryFunction from './jquery-function';
 import jQuery from 'jquery-deferred';
+import jqueryFunction from './jquery-function';
 import ajax from './ajax';
+
 module.exports = jQuery.extend(
   jqueryFunction,
   jQuery,
   {
-  defaultAjaxHeaders: null,
-  ajax: ajax,
-  inArray: (arr, item) => arr.indexOf(item) !== -1,
-  trim: str => str && str.trim(),
-  isEmptyObject: obj => !obj || Object.keys(obj).length === 0,
-  makeArray: arr => [].slice.call(arr, 0),
-  support: {
-    cors: true
+    defaultAjaxHeaders: null,
+    ajax,
+    inArray: (arr, item) => arr.indexOf(item) !== -1,
+    trim: str => str && str.trim(),
+    isEmptyObject: obj => !obj || Object.keys(obj).length === 0,
+    makeArray: arr => [].slice.call(arr, 0),
+    support: {
+      cors: true
+    }
   }
-});
+);