Skip to content

Commit 64b5b1c

Browse files
authored
Merge pull request syndtr#351 from manish-sethi/fsync_new_manifest
Add fsync after creating new manifest
2 parents 5c35d60 + eb13543 commit 64b5b1c

File tree

2 files changed

+17
-4
lines changed

2 files changed

+17
-4
lines changed

.travis.yml

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,19 @@
11
language: go
22

33
go:
4-
- 1.9.x
5-
- 1.10.x
6-
- 1.11.x
4+
- 1.14.x
5+
- 1.15.x
76
- tip
87

98
script:
10-
- go vet ./...
9+
- |
10+
(set -e
11+
if [ "$TRAVIS_GO_VERSION" != "tip" ]; then
12+
echo "executing go vet for go verion $TRAVIS_GO_VERSION"
13+
go vet ./...
14+
else
15+
echo "skipping go vet for go verion $TRAVIS_GO_VERSION"
16+
fi
17+
)
1118
- go test -timeout 1h ./...
1219
- go test -timeout 30m -race -run "TestDB_(Concurrent|GoleveldbIssue74)" ./leveldb

leveldb/session_util.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -453,6 +453,12 @@ func (s *session) newManifest(rec *sessionRecord, v *version) (err error) {
453453
if err != nil {
454454
return
455455
}
456+
if !s.o.GetNoSync() {
457+
err = writer.Sync()
458+
if err != nil {
459+
return
460+
}
461+
}
456462
err = s.stor.SetMeta(fd)
457463
return
458464
}

0 commit comments

Comments
 (0)