Skip to content

Commit 6da9284

Browse files
committed
Revert "Merge pull request marcuswestin#70 from shuizhongyueming/master"
This reverts commit 49579d6, reversing changes made to 18b51d2. The added changes only worked for iOS projects, but broke OSX builds.
1 parent 49579d6 commit 6da9284

File tree

2 files changed

+1
-35
lines changed

2 files changed

+1
-35
lines changed

WebViewJavascriptBridge/WebViewJavascriptBridge.h

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -22,28 +22,13 @@
2222
#define WVJB_WEBVIEW_DELEGATE_TYPE NSObject<UIWebViewDelegate>
2323
#endif
2424

25-
@protocol WebViewJavascriptBridgeDelegate<NSObject>
26-
27-
@optional
28-
29-
// define a method,make the user decide every request from webview should be load except the WVJB request
30-
-(BOOL) WVJB_webView:(UIWebView *)webView
31-
shouldStartLoadWithRequest:(NSURLRequest *)request
32-
navigationType:(UIWebViewNavigationType)navigationType;
33-
34-
35-
@end
36-
3725
typedef void (^WVJBResponseCallback)(id responseData);
3826
typedef void (^WVJBHandler)(id data, WVJBResponseCallback responseCallback);
3927

4028
@interface WebViewJavascriptBridge : WVJB_WEBVIEW_DELEGATE_TYPE
4129

42-
@property (nonatomic,weak) id <WebViewJavascriptBridgeDelegate> delegate;
43-
4430
+ (instancetype)bridgeForWebView:(WVJB_WEBVIEW_TYPE*)webView handler:(WVJBHandler)handler;
4531
+ (instancetype)bridgeForWebView:(WVJB_WEBVIEW_TYPE*)webView webViewDelegate:(WVJB_WEBVIEW_DELEGATE_TYPE*)webViewDelegate handler:(WVJBHandler)handler;
46-
+ (instancetype)bridgeForWebView:(WVJB_WEBVIEW_TYPE*)webView WVJBDelegate:(id)delegate handler:(WVJBHandler)handler;
4732
+ (instancetype)bridgeForWebView:(WVJB_WEBVIEW_TYPE*)webView webViewDelegate:(WVJB_WEBVIEW_DELEGATE_TYPE*)webViewDelegate handler:(WVJBHandler)handler resourceBundle:(NSBundle*)bundle;
4833
+ (void)enableLogging;
4934

WebViewJavascriptBridge/WebViewJavascriptBridge.m

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,6 @@ + (instancetype)bridgeForWebView:(WVJB_WEBVIEW_TYPE*)webView webViewDelegate:(WV
5252
WebViewJavascriptBridge* bridge = [[WebViewJavascriptBridge alloc] init];
5353
[bridge _platformSpecificSetup:webView webViewDelegate:webViewDelegate handler:messageHandler resourceBundle:bundle];
5454
[bridge reset];
55-
bridge.delegate = nil;
56-
return bridge;
57-
}
58-
59-
+ (instancetype)bridgeForWebView:(WVJB_WEBVIEW_TYPE*)webView WVJBDelegate:(id)delegate handler:(WVJBHandler)handler {
60-
WebViewJavascriptBridge* bridge = [[WebViewJavascriptBridge alloc] init];
61-
[bridge _platformSpecificSetup:webView webViewDelegate:nil handler:handler];
62-
[bridge reset];
63-
bridge.delegate = delegate;
6455
return bridge;
6556
}
6657

@@ -396,17 +387,7 @@ - (BOOL)webView:(UIWebView *)webView shouldStartLoadWithRequest:(NSURLRequest *)
396387
} else if (strongDelegate && [strongDelegate respondsToSelector:@selector(webView:shouldStartLoadWithRequest:navigationType:)]) {
397388
return [strongDelegate webView:webView shouldStartLoadWithRequest:request navigationType:navigationType];
398389
} else {
399-
if(self.delegate){
400-
if([self.delegate respondsToSelector:@selector(WVJB_webView:shouldStartLoadWithRequest:navigationType:)]){
401-
return [self.delegate WVJB_webView:webView
402-
shouldStartLoadWithRequest:request
403-
navigationType:navigationType];
404-
}else{
405-
return YES;
406-
}
407-
}else{
408-
return YES;
409-
}
390+
return YES;
410391
}
411392
}
412393

0 commit comments

Comments
 (0)