-
Notifications
You must be signed in to change notification settings - Fork 22
refactor: Simplify Provider Repository #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ion support Signed-off-by: André Silva <[email protected]>
…to internal Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
==========================================
- Coverage 87.35% 87.34% -0.01%
==========================================
Files 47 47
Lines 1827 1826 -1
Branches 190 190
==========================================
- Hits 1596 1595 -1
Misses 188 188
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…tor parameters Signed-off-by: André Silva <[email protected]>
|
@kinyoklion, can you please have a look at this PR again? |
|
@kinyoklion I'll merge this in the next 2 days unless I hear objections; it seems @askpt has resolved your suggestions. 🙏 |
|
Sorry for the delay. Taking a look now. |
No worries @kinyoklion! Thank you for the review! |
This PR
This pull request modifies the
ProviderRepositoryclass in thesrc/OpenFeature/ProviderRepository.csfile to improve cancellation support, streamline initialization and shutdown processes, and enhance compatibility across different .NET versions. The most notable changes include addingCancellationTokenparameters to several methods, updating method access modifiers, and simplifying object initializations.Cancellation Support Enhancements:
CancellationTokenparameters to methods such asSetProviderAsync,InitProviderAsync,ShutdownIfUnusedAsync, andSafeShutdownProviderAsyncto allow for operation cancellation. [1] [2] [3] [4] [5] [6]Method Access Modifier Updates:
publictointernal, includingSetProviderAsync,GetProvider, andShutdownAsync, to restrict their accessibility and better align with the class's intended usage. [1] [2] [3] [4]Compatibility Improvements:
string.IsNullOrWhiteSpacedifferently in .NET Framework and .NET Standard due to nullable compatibility issues. [1] [2]Code Simplifications:
{}forConcurrentDictionaryandReaderWriterLockSlim. [1] [2]