-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Support JSON Serialize for Value #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Weihan Li <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
==========================================
+ Coverage 87.88% 88.18% +0.30%
==========================================
Files 48 49 +1
Lines 1972 2049 +77
Branches 222 239 +17
==========================================
+ Hits 1733 1807 +74
Misses 191 191
- Partials 48 51 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Weihan Li <[email protected]>
Signed-off-by: Weihan Li <[email protected]>
Signed-off-by: Weihan Li <[email protected]>
Signed-off-by: Weihan Li <[email protected]>
Signed-off-by: Weihan Li <[email protected]>
Signed-off-by: Weihan Li <[email protected]>
Signed-off-by: Weihan Li <[email protected]>
5f8cb12 to
7c217aa
Compare
…st data Signed-off-by: Weihan Li <[email protected]>
Signed-off-by: Weihan Li <[email protected]>
cdf97d4 to
2ca8dd0
Compare
Signed-off-by: Weihan Li <[email protected]>
Signed-off-by: Weihan Li <[email protected]>
Signed-off-by: Weihan Li <[email protected]>
Signed-off-by: Weihan Li <[email protected]>
askpt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution.
This PR
ValueJsonConverterto support STJ JSON SerializeRelated Issues
Fixes #517
Notes
ValueJsonConverterto support STJ JSON Serialize, keep itinternalfor now, think we could make itpublicwhen necessaryFollow-up Tasks
ToJsonString()method likes LD SDK?Valueto a strong-typedT?How to test
refer to the unit test cases