-
Notifications
You must be signed in to change notification settings - Fork 22
fix: update provider status to Fatal during disposal #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update provider status to Fatal during disposal #580
Conversation
Signed-off-by: André Silva <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
=======================================
Coverage 89.73% 89.73%
=======================================
Files 64 64
Lines 2522 2523 +1
Branches 295 295
=======================================
+ Hits 2263 2264 +1
Misses 199 199
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a status management issue in the MultiProvider by ensuring the provider status is properly set to Fatal when the provider is disposed. This change ensures that the provider's status accurately reflects its disposed state after cleanup.
- Sets
_providerStatustoProviderStatus.Fatalafter disposing semaphores inDisposeAsyncmethod
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This doesn't appear thread-safe, but I assume that is a pre-existing issue, and probably needs addressed independently. |
Signed-off-by: André Silva [email protected]
This PR
This pull request makes a small change to the
DisposeAsyncmethod inMultiProvider.cs. After disposing of the semaphores, it now sets the_providerStatustoProviderStatus.Fatalto ensure the provider's status accurately reflects its disposed state.Related Issues
Fixes #569