Skip to content

refactor: InMemoryProvider throwing when types mismatched #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

refactor: InMemoryProvider throwing when types mismatched #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix isssue with InMemoryProvider throwing when types mismatched 
Signed-off-by: Kyle Julian <[email protected]>
  • Loading branch information
@kylejuliandev
kylejuliandev committed Apr 21, 2025
commit bd8360d9a1c7c739a02d69e9103323158d83b873
3 changes: 1 addition & 2 deletions src/OpenFeature/Providers/Memory/InMemoryProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
using System.Threading;
using System.Threading.Tasks;
using OpenFeature.Constant;
using OpenFeature.Error;
using OpenFeature.Model;

namespace OpenFeature.Providers.Memory
Expand Down Expand Up @@ -112,7 +111,7 @@ private ResolutionDetails<T> Resolve<T>(string flagKey, T defaultValue, Evaluati
return value.Evaluate(flagKey, defaultValue, context);
}

throw new TypeMismatchException($"flag {flagKey} is not of type {typeof(T)}");
return new ResolutionDetails<T>(flagKey, defaultValue, ErrorType.TypeMismatch, Reason.Error);
}
}
}
9 changes: 7 additions & 2 deletions test/OpenFeature.Tests/Providers/Memory/InMemoryProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,14 @@ public async Task MissingFlag_ShouldReturnFlagNotFoundEvaluationFlag()
}

[Fact]
public async Task MismatchedFlag_ShouldThrow()
public async Task MismatchedFlag_ShouldReturnTypeMismatchError()
{
await Assert.ThrowsAsync<TypeMismatchException>(() => this.commonProvider.ResolveStringValueAsync("boolean-flag", "nope", EvaluationContext.Empty));
// Act
var result = await this.commonProvider.ResolveStringValueAsync("boolean-flag", "nope", EvaluationContext.Empty);

// Assert
Assert.Equal(Reason.Error, result.Reason);
Assert.Equal(ErrorType.TypeMismatch, result.ErrorType);
}

[Fact]
Expand Down