deps: update jsonc import path #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-policy-agent#1132 Signed-off-by: Stefano Pentassuglia <[email protected]>
jalseth
approved these changes
May 29, 2025
Member
jalseth
left a comment
jalseth
left a comment
There was a problem hiding this comment.
I confirmed the previous URL now redirects to that GitHub account. Thanks!
$ curl -I https://muzzammil.xyz/jsonc?go-get=1
HTTP/2 301
date: Thu, 29 May 2025 23:07:30 GMT
content-type: text/html; charset=utf-8
location: /r?https://github.com/muhammadmuzzammil1998/jsonc
simonbaird
added a commit
to simonbaird/conforma-cli
that referenced
this pull request
Jul 24, 2025
I'm not sure exactly what the impact is, but IIUC we have not updated this for a while. Now that we updated opa, let's update this also. Required a little extra manual tweaking to remove the `replace muzzammil.xyz/jsonc ...` which is not needed now after open-policy-agent/conftest#1133 was merged. Ref: https://issues.redhat.com/browse/EC-1130
simonbaird
added a commit
to simonbaird/conforma-cli
that referenced
this pull request
Aug 4, 2025
I'm not sure exactly what the impact is, but IIUC we have not updated this for a while. Now that we updated opa, let's update this also. Required a little extra manual tweaking to remove the `replace muzzammil.xyz/jsonc ...` which is not needed now after open-policy-agent/conftest#1133 was merged. Ref: https://issues.redhat.com/browse/EC-1130
simonbaird
added a commit
to simonbaird/conforma-cli
that referenced
this pull request
Aug 5, 2025
I'm not sure exactly what the impact is, but we have not updated this for a while. Now that we updated opa, let's update this also. It required a little extra manual tweaking to remove the `replace muzzammil.xyz/jsonc ...` which is not needed now after open-policy-agent/conftest#1133 was merged. Ref: https://issues.redhat.com/browse/EC-1130
simonbaird
added a commit
to simonbaird/conforma-cli
that referenced
this pull request
Aug 5, 2025
Notably this is the first version of the conftest module that uses/supports the v1.x opa module. It required a little extra manual tweaking to remove the `replace muzzammil.xyz/jsonc ...` which is not needed now after open-policy-agent/conftest#1133 was merged. At this point I'm not sure exactly what the impact will be, but we have not updated this for a while. Now that we updated opa, let's update this also. Edit: There was quite a lot of impact actually, see the other commits in this PR. Ref: https://issues.redhat.com/browse/EC-1408 Ref: https://issues.redhat.com/browse/EC-1130
simonbaird
added a commit
to simonbaird/conforma-cli
that referenced
this pull request
Aug 6, 2025
Notably this is the first version of the conftest module that uses/supports the v1.x opa module. It required a little extra manual tweaking to remove the `replace muzzammil.xyz/jsonc ...` which is not needed now after open-policy-agent/conftest#1133 was merged. At this point I'm not sure exactly what the impact will be, but we have not updated this for a while. Now that we updated opa, let's update this also. Edit: There was quite a lot of impact actually, see the other commits in this PR. Ref: https://issues.redhat.com/browse/EC-1408 Ref: https://issues.redhat.com/browse/EC-1130
simonbaird
added a commit
to simonbaird/conforma-cli
that referenced
this pull request
Aug 7, 2025
Notably this is the first version of the conftest module that uses/supports the v1.x opa module. It required a little extra manual tweaking to remove the `replace muzzammil.xyz/jsonc ...` which is not needed now after open-policy-agent/conftest#1133 was merged. At this point I'm not sure exactly what the impact will be, but we have not updated this for a while. Now that we updated opa, let's update this also. Edit: There was quite a lot of impact actually, see the other commits in this PR. Ref: https://issues.redhat.com/browse/EC-1408 Ref: https://issues.redhat.com/browse/EC-1130
simonbaird
added a commit
to simonbaird/conforma-cli
that referenced
this pull request
Aug 8, 2025
Notably this is the first version of the conftest module that uses/supports the v1.x opa module. It required a little extra manual tweaking to remove the `replace muzzammil.xyz/jsonc ...` which is not needed now after open-policy-agent/conftest#1133 was merged. At this point I'm not sure exactly what the impact will be, but we have not updated this for a while. Now that we updated opa, let's update this also. Edit: There was quite a lot of impact actually, see the other commits in this PR. Ref: https://issues.redhat.com/browse/EC-1408 Ref: https://issues.redhat.com/browse/EC-1130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
jsonclib maintainer changed where the repo is hosted. This commit updates the import path of the dependency accordingly, in order to avoid potential issues while runninggo mod downloadFixes #1132