From 894bc110910aa6e942a41d54bd6a72cd2e70e95e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20Kie=C5=82kowicz?= Date: Wed, 4 Dec 2024 09:22:07 +0100 Subject: [PATCH 1/3] Replace ActivityExtensions.SetStatus by Activity.SetStatus --- src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md | 4 ++++ .../Implementation/Tracing/AWSTraceSpan.cs | 5 +---- .../AWSLambdaWrapper.cs | 4 +--- .../CHANGELOG.md | 4 ++++ .../CHANGELOG.md | 4 ++++ .../OpenTelemetryConsumeResultExtensions.cs | 4 +--- .../CHANGELOG.md | 4 ++++ .../EntityFrameworkDiagnosticListener.cs | 5 +---- src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md | 4 ++++ .../Implementation/DiagnosticsMiddleware.cs | 4 +--- .../CHANGELOG.md | 4 ++++ .../Implementation/QuartzDiagnosticListener.cs | 5 +---- src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md | 4 ++++ .../Implementation/ClientChannelInstrumentation.cs | 5 +---- .../TelemetryDispatchMessageInspector.cs | 5 +---- .../AWSLambdaWrapperTests.cs | 7 +++++-- .../EntityFrameworkDiagnosticListenerTests.cs | 1 - .../QuartzDiagnosticListenerTests.cs | 13 ++++++++----- 18 files changed, 49 insertions(+), 37 deletions(-) diff --git a/src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md index ff3c2ba693..95b98db400 100644 --- a/src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +* Following tags will be not added to spans when the exception is recorder: + `otel.status_code` and `otel.status_description`. Both values are handled natively. + ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) + ## 1.10.0-beta.1 Released 2024-Nov-23 diff --git a/src/OpenTelemetry.Instrumentation.AWS/Implementation/Tracing/AWSTraceSpan.cs b/src/OpenTelemetry.Instrumentation.AWS/Implementation/Tracing/AWSTraceSpan.cs index a825155d7f..c390c6bbd9 100644 --- a/src/OpenTelemetry.Instrumentation.AWS/Implementation/Tracing/AWSTraceSpan.cs +++ b/src/OpenTelemetry.Instrumentation.AWS/Implementation/Tracing/AWSTraceSpan.cs @@ -4,7 +4,6 @@ using System.Diagnostics; using Amazon.Runtime.Telemetry; using Amazon.Runtime.Telemetry.Tracing; -using OpenTelemetry.Trace; namespace OpenTelemetry.Instrumentation.AWS.Implementation.Tracing; @@ -60,9 +59,7 @@ public override void RecordException(Exception exception, Attributes? attributes var tags = attributes != null ? new TagList(attributes.AllAttributes.ToArray()) : default; this.activity.AddException(exception, tags); -#pragma warning disable CS0618 // Type or member is obsolete - this.activity.SetStatus(Status.Error.WithDescription(exception.Message)); -#pragma warning restore CS0618 // Type or member is obsolete + this.activity.SetStatus(ActivityStatusCode.Error, exception.Message); } public override void End() diff --git a/src/OpenTelemetry.Instrumentation.AWSLambda/AWSLambdaWrapper.cs b/src/OpenTelemetry.Instrumentation.AWSLambda/AWSLambdaWrapper.cs index ab5930feec..7dbe014fbb 100644 --- a/src/OpenTelemetry.Instrumentation.AWSLambda/AWSLambdaWrapper.cs +++ b/src/OpenTelemetry.Instrumentation.AWSLambda/AWSLambdaWrapper.cs @@ -192,9 +192,7 @@ private static void OnException(Activity? activity, Exception exception) if (activity.IsAllDataRequested) { activity.AddException(exception); -#pragma warning disable CS0618 // Type or member is obsolete - activity.SetStatus(Status.Error.WithDescription(exception.Message)); -#pragma warning restore CS0618 // Type or member is obsolete + activity.SetStatus(ActivityStatusCode.Error, exception.Message); } } } diff --git a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md index 0e1193c2d2..0098873f03 100644 --- a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +* Following tags will be not added to spans when the exception is recorder: + `otel.status_code` and `otel.status_description`. Both values are handled natively. + ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) + ## 1.10.0-beta.1 Released 2024-Nov-23 diff --git a/src/OpenTelemetry.Instrumentation.ConfluentKafka/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.ConfluentKafka/CHANGELOG.md index cfa2dcb4f8..2c48354ab2 100644 --- a/src/OpenTelemetry.Instrumentation.ConfluentKafka/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.ConfluentKafka/CHANGELOG.md @@ -9,6 +9,10 @@ * Updated OpenTelemetry core component version(s) to `1.10.0`. ([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317)) +* Following tags will be not added to spans when the exception is handled: + `otel.status_code` and `otel.status_description`. Both values are handled natively. + ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) + ## 0.1.0-alpha.2 Released 2024-Sep-18 diff --git a/src/OpenTelemetry.Instrumentation.ConfluentKafka/OpenTelemetryConsumeResultExtensions.cs b/src/OpenTelemetry.Instrumentation.ConfluentKafka/OpenTelemetryConsumeResultExtensions.cs index c1d650e2aa..2b67de516d 100644 --- a/src/OpenTelemetry.Instrumentation.ConfluentKafka/OpenTelemetryConsumeResultExtensions.cs +++ b/src/OpenTelemetry.Instrumentation.ConfluentKafka/OpenTelemetryConsumeResultExtensions.cs @@ -113,9 +113,7 @@ public static bool TryExtractPropagationContext( } catch (Exception ex) { -#pragma warning disable CS0618 // Type or member is obsolete - processActivity?.SetStatus(Status.Error); -#pragma warning restore CS0618 // Type or member is obsolete + processActivity?.SetStatus(ActivityStatusCode.Error); processActivity?.SetTag(SemanticConventions.AttributeErrorType, ex.GetType().FullName); } finally diff --git a/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md index 0522374f01..686dbb7d97 100644 --- a/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md @@ -27,6 +27,10 @@ * Updated OpenTelemetry core component version(s) to `1.10.0`. ([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317)) +* Following tags will be not added to spans when the exception is handled: + `otel.status_code` and `otel.status_description`. Both values are handled natively. + ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) + ## 1.0.0-beta.12 Released 2024-Jun-18 diff --git a/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/Implementation/EntityFrameworkDiagnosticListener.cs b/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/Implementation/EntityFrameworkDiagnosticListener.cs index 630a8ebef7..509402f807 100644 --- a/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/Implementation/EntityFrameworkDiagnosticListener.cs +++ b/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/Implementation/EntityFrameworkDiagnosticListener.cs @@ -5,7 +5,6 @@ using System.Diagnostics; using System.Reflection; using OpenTelemetry.Internal; -using OpenTelemetry.Trace; namespace OpenTelemetry.Instrumentation.EntityFrameworkCore.Implementation; @@ -297,9 +296,7 @@ public override void OnEventWritten(string name, object? payload) { if (this.exceptionFetcher.Fetch(payload) is Exception exception) { -#pragma warning disable CS0618 // Type or member is obsolete - activity.SetStatus(Status.Error.WithDescription(exception.Message)); -#pragma warning restore CS0618 // Type or member is obsolete + activity.SetStatus(ActivityStatusCode.Error, exception.Message); } else { diff --git a/src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md index 956886a70b..90c998bff8 100644 --- a/src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md @@ -19,6 +19,10 @@ * Updated OpenTelemetry core component version(s) to `1.10.0`. ([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317)) +* Following tags will be not added to spans when the exception is handled: + `otel.status_code` and `otel.status_description`. Both values are handled natively. + ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) + ## 1.0.0-rc.6 Released 2024-Apr-19 diff --git a/src/OpenTelemetry.Instrumentation.Owin/Implementation/DiagnosticsMiddleware.cs b/src/OpenTelemetry.Instrumentation.Owin/Implementation/DiagnosticsMiddleware.cs index bc509a794d..a112528ae2 100644 --- a/src/OpenTelemetry.Instrumentation.Owin/Implementation/DiagnosticsMiddleware.cs +++ b/src/OpenTelemetry.Instrumentation.Owin/Implementation/DiagnosticsMiddleware.cs @@ -150,9 +150,7 @@ private static void RequestEnd(IOwinContext owinContext, Exception? exception, l if (exception != null) { -#pragma warning disable CS0618 // Type or member is obsolete - activity.SetStatus(Status.Error); -#pragma warning restore CS0618 // Type or member is obsolete + activity.SetStatus(ActivityStatusCode.Error); if (OwinInstrumentationActivitySource.Options?.RecordException == true) { diff --git a/src/OpenTelemetry.Instrumentation.Quartz/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.Quartz/CHANGELOG.md index f9ad69cdbf..564e72b70f 100644 --- a/src/OpenTelemetry.Instrumentation.Quartz/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.Quartz/CHANGELOG.md @@ -5,6 +5,10 @@ * Updated OpenTelemetry core component version(s) to `1.10.0`. ([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317)) +* Following tags will be not added to spans when the exception is recorder: + `otel.status_code` and `otel.status_description`. Both values are handled natively. + ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) + ## 1.0.0-beta.3 Released 2024-Jun-18 diff --git a/src/OpenTelemetry.Instrumentation.Quartz/Implementation/QuartzDiagnosticListener.cs b/src/OpenTelemetry.Instrumentation.Quartz/Implementation/QuartzDiagnosticListener.cs index 242df493f5..cd940ba04b 100644 --- a/src/OpenTelemetry.Instrumentation.Quartz/Implementation/QuartzDiagnosticListener.cs +++ b/src/OpenTelemetry.Instrumentation.Quartz/Implementation/QuartzDiagnosticListener.cs @@ -4,7 +4,6 @@ using System.Diagnostics; using System.Reflection; using OpenTelemetry.Internal; -using OpenTelemetry.Trace; namespace OpenTelemetry.Instrumentation.Quartz.Implementation; @@ -140,9 +139,7 @@ private void OnException(Activity activity, object? payload) activity.AddException(exc); } -#pragma warning disable CS0618 // Type or member is obsolete - activity.SetStatus(Status.Error.WithDescription(exc.Message)); -#pragma warning restore CS0618 // Type or member is obsolete + activity.SetStatus(ActivityStatusCode.Error, exc.Message); try { diff --git a/src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md index 00310a2e3c..f8c573da60 100644 --- a/src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md @@ -12,6 +12,10 @@ recorded (defaults to `false`). This is only supported by client instrumentation. ([#2271](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2271)) +* Following tags will be not added to spans when the request is faulted: + `otel.status_code` and `otel.status_description`. Both values are handled natively. + ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) + ## 1.0.0-rc.18 Released 2024-Oct-28 diff --git a/src/OpenTelemetry.Instrumentation.Wcf/Implementation/ClientChannelInstrumentation.cs b/src/OpenTelemetry.Instrumentation.Wcf/Implementation/ClientChannelInstrumentation.cs index c6e56f2b34..e33f07c0a8 100644 --- a/src/OpenTelemetry.Instrumentation.Wcf/Implementation/ClientChannelInstrumentation.cs +++ b/src/OpenTelemetry.Instrumentation.Wcf/Implementation/ClientChannelInstrumentation.cs @@ -5,7 +5,6 @@ using System.ServiceModel.Channels; using OpenTelemetry.Context.Propagation; using OpenTelemetry.Internal; -using OpenTelemetry.Trace; namespace OpenTelemetry.Instrumentation.Wcf.Implementation; @@ -92,9 +91,7 @@ public static void AfterRequestCompleted(Message? reply, RequestTelemetryState? { if (reply == null || reply.IsFault) { -#pragma warning disable CS0618 // Type or member is obsolete - activity.SetStatus(Status.Error); -#pragma warning restore CS0618 // Type or member is obsolete + activity.SetStatus(ActivityStatusCode.Error); if (WcfInstrumentationActivitySource.Options!.RecordException && exception != null) { diff --git a/src/OpenTelemetry.Instrumentation.Wcf/Implementation/TelemetryDispatchMessageInspector.cs b/src/OpenTelemetry.Instrumentation.Wcf/Implementation/TelemetryDispatchMessageInspector.cs index 3741f0b832..c32dffb8b8 100644 --- a/src/OpenTelemetry.Instrumentation.Wcf/Implementation/TelemetryDispatchMessageInspector.cs +++ b/src/OpenTelemetry.Instrumentation.Wcf/Implementation/TelemetryDispatchMessageInspector.cs @@ -8,7 +8,6 @@ using System.ServiceModel.Dispatcher; using OpenTelemetry.Context.Propagation; using OpenTelemetry.Internal; -using OpenTelemetry.Trace; namespace OpenTelemetry.Instrumentation.Wcf.Implementation; @@ -123,9 +122,7 @@ public void BeforeSendReply(ref Message reply, object? correlationState) { if (reply.IsFault) { -#pragma warning disable CS0618 // Type or member is obsolete - activity.SetStatus(Status.Error); -#pragma warning restore CS0618 // Type or member is obsolete + activity.SetStatus(ActivityStatusCode.Error); } activity.SetTag(WcfInstrumentationConstants.SoapReplyActionTag, reply.Headers.Action); diff --git a/test/OpenTelemetry.Instrumentation.AWSLambda.Tests/AWSLambdaWrapperTests.cs b/test/OpenTelemetry.Instrumentation.AWSLambda.Tests/AWSLambdaWrapperTests.cs index d36277b099..a63ec740b2 100644 --- a/test/OpenTelemetry.Instrumentation.AWSLambda.Tests/AWSLambdaWrapperTests.cs +++ b/test/OpenTelemetry.Instrumentation.AWSLambda.Tests/AWSLambdaWrapperTests.cs @@ -279,7 +279,10 @@ private void AssertSpanAttributes(Activity activity) private void AssertSpanException(Activity activity) { - Assert.Equal("ERROR", activity.GetTagValue(SpanAttributeConstants.StatusCodeKey)); - Assert.NotNull(activity.GetTagValue(SpanAttributeConstants.StatusDescriptionKey)); + Assert.Equal(ActivityStatusCode.Error, activity.Status); + Assert.Equal("TestException", activity.StatusDescription); + var exception = Assert.Single(activity.Events); + Assert.Equal("exception", exception.Name); + Assert.Equal("TestException", exception.Tags.SingleOrDefault(t => t.Key.Equals("exception.message")).Value); } } diff --git a/test/OpenTelemetry.Instrumentation.EntityFrameworkCore.Tests/EntityFrameworkDiagnosticListenerTests.cs b/test/OpenTelemetry.Instrumentation.EntityFrameworkCore.Tests/EntityFrameworkDiagnosticListenerTests.cs index 7974ef93de..e96a059844 100644 --- a/test/OpenTelemetry.Instrumentation.EntityFrameworkCore.Tests/EntityFrameworkDiagnosticListenerTests.cs +++ b/test/OpenTelemetry.Instrumentation.EntityFrameworkCore.Tests/EntityFrameworkDiagnosticListenerTests.cs @@ -289,7 +289,6 @@ private static void VerifyActivityData(Activity activity, bool isError = false, { Assert.Equal(ActivityStatusCode.Error, activity.Status); Assert.Equal("SQLite Error 1: 'no such table: no_table'.", activity.StatusDescription); - Assert.Contains(activity.Tags, t => t.Key == SpanAttributeConstants.StatusDescriptionKey); } } diff --git a/test/OpenTelemetry.Instrumentation.Quartz.Tests/QuartzDiagnosticListenerTests.cs b/test/OpenTelemetry.Instrumentation.Quartz.Tests/QuartzDiagnosticListenerTests.cs index 09289ecf17..980361f98e 100644 --- a/test/OpenTelemetry.Instrumentation.Quartz.Tests/QuartzDiagnosticListenerTests.cs +++ b/test/OpenTelemetry.Instrumentation.Quartz.Tests/QuartzDiagnosticListenerTests.cs @@ -186,9 +186,10 @@ public async Task Should_Record_Exception_When_Record_Exception_Enabled() Assert.Single(exportedItems); var activity = exportedItems[0]; - Assert.Equal("exception", activity.Events.First().Name); - Assert.Equal("ERROR", activity.Tags.SingleOrDefault(t => t.Key.Equals(SpanAttributeConstants.StatusCodeKey)).Value); - Assert.Equal("Catch me if you can!", activity.Tags.SingleOrDefault(t => t.Key.Equals(SpanAttributeConstants.StatusDescriptionKey)).Value); + Assert.Equal(ActivityStatusCode.Error, activity.Status); + var exception = Assert.Single(activity.Events); + Assert.Equal("exception", exception.Name); + Assert.Equal("Catch me if you can!", exception.Tags.SingleOrDefault(t => t.Key.Equals("exception.message")).Value); } [Fact] @@ -253,8 +254,10 @@ public async Task Should_Enrich_Exception_When_Record_Exception_Enabled_And_Enri Assert.Single(exportedItems); var activity = exportedItems[0]; - Assert.Equal("ERROR", activity.Tags.SingleOrDefault(t => t.Key.Equals(SpanAttributeConstants.StatusCodeKey)).Value); - Assert.Equal("Catch me if you can!", activity.Tags.SingleOrDefault(t => t.Key.Equals(SpanAttributeConstants.StatusDescriptionKey)).Value); + Assert.Equal(ActivityStatusCode.Error, activity.Status); + var exception = Assert.Single(activity.Events); + Assert.Equal("exception", exception.Name); + Assert.Equal("Catch me if you can!", exception.Tags.SingleOrDefault(t => t.Key.Equals("exception.message")).Value); Assert.Equal(testId, activity.Tags.SingleOrDefault(t => t.Key.Equals("test.id")).Value); } From 214cad3aba3be7d9bfb5597e3a2df4a8aed63209 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20Kie=C5=82kowicz?= Date: Thu, 5 Dec 2024 10:22:40 +0100 Subject: [PATCH 2/3] Improve changelogs --- src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md | 2 +- src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md | 2 +- src/OpenTelemetry.Instrumentation.ConfluentKafka/CHANGELOG.md | 2 +- .../CHANGELOG.md | 2 +- src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md | 2 +- src/OpenTelemetry.Instrumentation.Quartz/CHANGELOG.md | 2 +- src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md index 95b98db400..44ddcd7885 100644 --- a/src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md @@ -2,7 +2,7 @@ ## Unreleased -* Following tags will be not added to spans when the exception is recorder: +* The following tags are no longer added to spans when an exception is recorded: `otel.status_code` and `otel.status_description`. Both values are handled natively. ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) diff --git a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md index 0098873f03..fd20042b4b 100644 --- a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md @@ -2,7 +2,7 @@ ## Unreleased -* Following tags will be not added to spans when the exception is recorder: +* The following tags are no longer added to spans when an exception is recorded: `otel.status_code` and `otel.status_description`. Both values are handled natively. ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) diff --git a/src/OpenTelemetry.Instrumentation.ConfluentKafka/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.ConfluentKafka/CHANGELOG.md index 2c48354ab2..65fe109095 100644 --- a/src/OpenTelemetry.Instrumentation.ConfluentKafka/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.ConfluentKafka/CHANGELOG.md @@ -9,7 +9,7 @@ * Updated OpenTelemetry core component version(s) to `1.10.0`. ([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317)) -* Following tags will be not added to spans when the exception is handled: +* FThe following tags are no longer added to spans when an exception is handled: `otel.status_code` and `otel.status_description`. Both values are handled natively. ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) diff --git a/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md index 686dbb7d97..1d04c9a91f 100644 --- a/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md @@ -27,7 +27,7 @@ * Updated OpenTelemetry core component version(s) to `1.10.0`. ([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317)) -* Following tags will be not added to spans when the exception is handled: +* The following tags are no longer added to spans when an exception is handled: `otel.status_code` and `otel.status_description`. Both values are handled natively. ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) diff --git a/src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md index 90c998bff8..e2a6dfea23 100644 --- a/src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md @@ -19,7 +19,7 @@ * Updated OpenTelemetry core component version(s) to `1.10.0`. ([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317)) -* Following tags will be not added to spans when the exception is handled: +* The following tags are no longer added to spans when an exception is handled: `otel.status_code` and `otel.status_description`. Both values are handled natively. ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) diff --git a/src/OpenTelemetry.Instrumentation.Quartz/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.Quartz/CHANGELOG.md index 564e72b70f..041579a4ef 100644 --- a/src/OpenTelemetry.Instrumentation.Quartz/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.Quartz/CHANGELOG.md @@ -5,7 +5,7 @@ * Updated OpenTelemetry core component version(s) to `1.10.0`. ([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317)) -* Following tags will be not added to spans when the exception is recorder: +* The following tags are no longer added to spans when an exception is recorded: `otel.status_code` and `otel.status_description`. Both values are handled natively. ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) diff --git a/src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md index f8c573da60..349673f214 100644 --- a/src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md @@ -12,7 +12,7 @@ recorded (defaults to `false`). This is only supported by client instrumentation. ([#2271](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2271)) -* Following tags will be not added to spans when the request is faulted: +* The following tags are no longer added to spans when a request is faulted: `otel.status_code` and `otel.status_description`. Both values are handled natively. ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) From e25bdc82fc4038d0c6b8617bb26808e3cb48efa7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20Kie=C5=82kowicz?= Date: Fri, 6 Dec 2024 07:05:05 +0100 Subject: [PATCH 3/3] CHANGELOG - pr feedback Co-authored-by: Mikel Blanchard --- src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md | 5 +++-- src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md | 5 +++-- .../CHANGELOG.md | 5 +++-- .../CHANGELOG.md | 5 +++-- src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md | 5 +++-- src/OpenTelemetry.Instrumentation.Quartz/CHANGELOG.md | 5 +++-- src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md | 5 +++-- 7 files changed, 21 insertions(+), 14 deletions(-) diff --git a/src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md index 44ddcd7885..a0e7c5398e 100644 --- a/src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md @@ -2,8 +2,9 @@ ## Unreleased -* The following tags are no longer added to spans when an exception is recorded: - `otel.status_code` and `otel.status_description`. Both values are handled natively. +* Trace instrumentation will now call the [Activity.SetStatus](https://learn.microsoft.com/dotnet/api/system.diagnostics.activity.setstatus) + API instead of the deprecated OpenTelemetry API package extension when setting + span status. For details see: [Setting Status](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Api/README.md#setting-status). ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) ## 1.10.0-beta.1 diff --git a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md index fd20042b4b..f57beb4e4d 100644 --- a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md @@ -2,8 +2,9 @@ ## Unreleased -* The following tags are no longer added to spans when an exception is recorded: - `otel.status_code` and `otel.status_description`. Both values are handled natively. +* Trace instrumentation will now call the [Activity.SetStatus](https://learn.microsoft.com/dotnet/api/system.diagnostics.activity.setstatus) + API instead of the deprecated OpenTelemetry API package extension when setting + span status. For details see: [Setting Status](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Api/README.md#setting-status). ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) ## 1.10.0-beta.1 diff --git a/src/OpenTelemetry.Instrumentation.ConfluentKafka/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.ConfluentKafka/CHANGELOG.md index 65fe109095..bd314a325b 100644 --- a/src/OpenTelemetry.Instrumentation.ConfluentKafka/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.ConfluentKafka/CHANGELOG.md @@ -9,8 +9,9 @@ * Updated OpenTelemetry core component version(s) to `1.10.0`. ([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317)) -* FThe following tags are no longer added to spans when an exception is handled: - `otel.status_code` and `otel.status_description`. Both values are handled natively. +* Trace instrumentation will now call the [Activity.SetStatus](https://learn.microsoft.com/dotnet/api/system.diagnostics.activity.setstatus) + API instead of the deprecated OpenTelemetry API package extension when setting + span status. For details see: [Setting Status](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Api/README.md#setting-status). ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) ## 0.1.0-alpha.2 diff --git a/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md index 1d04c9a91f..8b43e2c59d 100644 --- a/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md @@ -27,8 +27,9 @@ * Updated OpenTelemetry core component version(s) to `1.10.0`. ([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317)) -* The following tags are no longer added to spans when an exception is handled: - `otel.status_code` and `otel.status_description`. Both values are handled natively. +* Trace instrumentation will now call the [Activity.SetStatus](https://learn.microsoft.com/dotnet/api/system.diagnostics.activity.setstatus) + API instead of the deprecated OpenTelemetry API package extension when setting + span status. For details see: [Setting Status](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Api/README.md#setting-status). ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) ## 1.0.0-beta.12 diff --git a/src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md index e2a6dfea23..89a4131868 100644 --- a/src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md @@ -19,8 +19,9 @@ * Updated OpenTelemetry core component version(s) to `1.10.0`. ([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317)) -* The following tags are no longer added to spans when an exception is handled: - `otel.status_code` and `otel.status_description`. Both values are handled natively. +* Trace instrumentation will now call the [Activity.SetStatus](https://learn.microsoft.com/dotnet/api/system.diagnostics.activity.setstatus) + API instead of the deprecated OpenTelemetry API package extension when setting + span status. For details see: [Setting Status](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Api/README.md#setting-status). ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) ## 1.0.0-rc.6 diff --git a/src/OpenTelemetry.Instrumentation.Quartz/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.Quartz/CHANGELOG.md index 041579a4ef..92b0d94fe4 100644 --- a/src/OpenTelemetry.Instrumentation.Quartz/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.Quartz/CHANGELOG.md @@ -5,8 +5,9 @@ * Updated OpenTelemetry core component version(s) to `1.10.0`. ([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317)) -* The following tags are no longer added to spans when an exception is recorded: - `otel.status_code` and `otel.status_description`. Both values are handled natively. +* Trace instrumentation will now call the [Activity.SetStatus](https://learn.microsoft.com/dotnet/api/system.diagnostics.activity.setstatus) + API instead of the deprecated OpenTelemetry API package extension when setting + span status. For details see: [Setting Status](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Api/README.md#setting-status). ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) ## 1.0.0-beta.3 diff --git a/src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md index 349673f214..60993f36e1 100644 --- a/src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md @@ -12,8 +12,9 @@ recorded (defaults to `false`). This is only supported by client instrumentation. ([#2271](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2271)) -* The following tags are no longer added to spans when a request is faulted: - `otel.status_code` and `otel.status_description`. Both values are handled natively. +* Trace instrumentation will now call the [Activity.SetStatus](https://learn.microsoft.com/dotnet/api/system.diagnostics.activity.setstatus) + API instead of the deprecated OpenTelemetry API package extension when setting + span status. For details see: [Setting Status](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Api/README.md#setting-status). ([#2358](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2358)) ## 1.0.0-rc.18