Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.

Commit 56f11e2

Browse files
author
naseemkullah
committed
chore: make startActiveSpan required in the tracer interface
Signed-off-by: naseemkullah <naseem@transit.app>
1 parent b53dd2f commit 56f11e2

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

src/trace/ProxyTracer.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,9 @@ export class ProxyTracer implements Tracer {
3838
return this._getTracer().startSpan(name, options, context);
3939
}
4040

41-
startActiveSpan?<F extends (span: Span) => ReturnType<F>>():
42-
| ReturnType<F>
43-
| undefined {
41+
startActiveSpan<F extends (span: Span) => ReturnType<F>>(): ReturnType<F> {
4442
const tracer = this._getTracer();
45-
46-
if (tracer.startActiveSpan) {
47-
return Reflect.apply(tracer.startActiveSpan, tracer, arguments);
48-
}
49-
return;
43+
return Reflect.apply(tracer.startActiveSpan, tracer, arguments);
5044
}
5145

5246
/**

src/trace/tracer.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,16 +78,16 @@ export interface Tracer {
7878
* do some more work
7979
* span.end();
8080
*/
81-
startActiveSpan?<F extends (span: Span) => ReturnType<F>>(
81+
startActiveSpan<F extends (span: Span) => ReturnType<F>>(
8282
name: string,
8383
fn: F
8484
): ReturnType<F>;
85-
startActiveSpan?<F extends (span: Span) => ReturnType<F>>(
85+
startActiveSpan<F extends (span: Span) => ReturnType<F>>(
8686
name: string,
8787
options: SpanOptions,
8888
fn: F
8989
): ReturnType<F>;
90-
startActiveSpan?<F extends (span: Span) => ReturnType<F>>(
90+
startActiveSpan<F extends (span: Span) => ReturnType<F>>(
9191
name: string,
9292
options: SpanOptions,
9393
context: Context,

0 commit comments

Comments
 (0)