Skip to content

Commit 8db2c3e

Browse files
refactor(core): Use exported strings for semconv
1 parent 82b7526 commit 8db2c3e

File tree

2 files changed

+18
-14
lines changed

2 files changed

+18
-14
lines changed

packages/opentelemetry-core/src/platform/browser/sdk-info.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,17 @@
1616

1717
import { VERSION } from '../../version';
1818
import {
19-
TelemetrySdkLanguageValues,
20-
SemanticResourceAttributes,
19+
SEMRESATTRS_TELEMETRY_SDK_NAME,
20+
SEMRESATTRS_PROCESS_RUNTIME_NAME,
21+
SEMRESATTRS_TELEMETRY_SDK_LANGUAGE,
22+
TELEMETRYSDKLANGUAGEVALUES_WEBJS,
23+
SEMRESATTRS_TELEMETRY_SDK_VERSION,
2124
} from '@opentelemetry/semantic-conventions';
2225

2326
/** Constants describing the SDK in use */
2427
export const SDK_INFO = {
25-
[SemanticResourceAttributes.TELEMETRY_SDK_NAME]: 'opentelemetry',
26-
[SemanticResourceAttributes.PROCESS_RUNTIME_NAME]: 'browser',
27-
[SemanticResourceAttributes.TELEMETRY_SDK_LANGUAGE]:
28-
TelemetrySdkLanguageValues.WEBJS,
29-
[SemanticResourceAttributes.TELEMETRY_SDK_VERSION]: VERSION,
28+
[SEMRESATTRS_TELEMETRY_SDK_NAME]: 'opentelemetry',
29+
[SEMRESATTRS_PROCESS_RUNTIME_NAME]: 'browser',
30+
[SEMRESATTRS_TELEMETRY_SDK_LANGUAGE]: TELEMETRYSDKLANGUAGEVALUES_WEBJS,
31+
[SEMRESATTRS_TELEMETRY_SDK_VERSION]: VERSION,
3032
};

packages/opentelemetry-core/src/platform/node/sdk-info.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,17 @@
1616

1717
import { VERSION } from '../../version';
1818
import {
19-
TelemetrySdkLanguageValues,
20-
SemanticResourceAttributes,
19+
SEMRESATTRS_TELEMETRY_SDK_NAME,
20+
SEMRESATTRS_PROCESS_RUNTIME_NAME,
21+
SEMRESATTRS_TELEMETRY_SDK_LANGUAGE,
22+
TELEMETRYSDKLANGUAGEVALUES_NODEJS,
23+
SEMRESATTRS_TELEMETRY_SDK_VERSION,
2124
} from '@opentelemetry/semantic-conventions';
2225

2326
/** Constants describing the SDK in use */
2427
export const SDK_INFO = {
25-
[SemanticResourceAttributes.TELEMETRY_SDK_NAME]: 'opentelemetry',
26-
[SemanticResourceAttributes.PROCESS_RUNTIME_NAME]: 'node',
27-
[SemanticResourceAttributes.TELEMETRY_SDK_LANGUAGE]:
28-
TelemetrySdkLanguageValues.NODEJS,
29-
[SemanticResourceAttributes.TELEMETRY_SDK_VERSION]: VERSION,
28+
[SEMRESATTRS_TELEMETRY_SDK_NAME]: 'opentelemetry',
29+
[SEMRESATTRS_PROCESS_RUNTIME_NAME]: 'node',
30+
[SEMRESATTRS_TELEMETRY_SDK_LANGUAGE]: TELEMETRYSDKLANGUAGEVALUES_NODEJS,
31+
[SEMRESATTRS_TELEMETRY_SDK_VERSION]: VERSION,
3032
};

0 commit comments

Comments
 (0)