Skip to content

Commit 929e345

Browse files
refactor(examples/grpc-js): use new exported string constants for semconv (#4760)
* refactor(examples/grpc-js): use new exported string constants for semconv * updated semconv package ^1.22.0 * added changelog entry --------- Co-authored-by: Marc Pichler <[email protected]>
1 parent 97f372b commit 929e345

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
2727
### :books: (Refine Doc)
2828

2929
* refactor(examples): use new exported string constants for semconv in examples/http [#4750](https://github.com/open-telemetry/opentelemetry-js/pull/4750) @Zen-cronic
30+
* refactor(examples): use new exported string constants for semconv in examples/grpc-js [#4760](https://github.com/open-telemetry/opentelemetry-js/pull/4760#pull) @Zen-cronic
3031
* refactor(examples): use new exported string constants for semconv in examples/otlp-exporter-node [#4762](https://github.com/open-telemetry/opentelemetry-js/pull/4762) @Zen-cronic
3132
* refactor(examples): use new exported string constants for semconv in examples/opentracing-shim [#4761](https://github.com/open-telemetry/opentelemetry-js/pull/4761) @Zen-cronic
3233

examples/grpc-js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"@opentelemetry/instrumentation": "^0.27.0",
3636
"@opentelemetry/instrumentation-grpc": "^0.27.0",
3737
"@opentelemetry/resources": "^1.0.1",
38-
"@opentelemetry/semantic-conventions": "^1.0.1",
38+
"@opentelemetry/semantic-conventions": "^1.22.0",
3939
"@opentelemetry/sdk-trace-base": "^1.0.1",
4040
"@opentelemetry/sdk-trace-node": "^1.0.1",
4141
"google-protobuf": "^3.9.2"

examples/grpc-js/tracer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const opentelemetry = require('@opentelemetry/api');
44
const { registerInstrumentations } = require('@opentelemetry/instrumentation');
55
const { NodeTracerProvider } = require('@opentelemetry/sdk-trace-node');
66
const { Resource } = require('@opentelemetry/resources');
7-
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
7+
const { SEMRESATTRS_SERVICE_NAME } = require('@opentelemetry/semantic-conventions');
88
const { SimpleSpanProcessor } = require('@opentelemetry/sdk-trace-base');
99
const { JaegerExporter } = require('@opentelemetry/exporter-jaeger');
1010
const { ZipkinExporter } = require('@opentelemetry/exporter-zipkin');
@@ -15,7 +15,7 @@ const EXPORTER = process.env.EXPORTER || '';
1515
module.exports = (serviceName) => {
1616
const provider = new NodeTracerProvider({
1717
resource: new Resource({
18-
[SemanticResourceAttributes.SERVICE_NAME]: serviceName,
18+
[SEMRESATTRS_SERVICE_NAME]: serviceName,
1919
}),
2020
});
2121

0 commit comments

Comments
 (0)