From 91fccf1c557127c0061648aff344f97afb1f214b Mon Sep 17 00:00:00 2001 From: Trent Mick Date: Thu, 15 Aug 2024 16:58:10 -0700 Subject: [PATCH 1/2] fix(instrumentation): drop diag.debug on InstrumentationBase#init not returning any modules Closes: #2237 Refs: #3308 --- .../src/platform/node/instrumentation.ts | 8 -------- 1 file changed, 8 deletions(-) diff --git a/experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts b/experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts index cad74be5a08..b69e91dfebf 100644 --- a/experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts +++ b/experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts @@ -66,14 +66,6 @@ export abstract class InstrumentationBase< this._modules = (modules as InstrumentationModuleDefinition[]) || []; - if (this._modules.length === 0) { - diag.debug( - 'No modules instrumentation has been defined for ' + - `'${this.instrumentationName}@${this.instrumentationVersion}'` + - ', nothing will be patched' - ); - } - if (this._config.enabled) { this.enable(); } From ae8f4a685702d6400e6939feb4b201f42d421409 Mon Sep 17 00:00:00 2001 From: Trent Mick Date: Thu, 15 Aug 2024 17:05:47 -0700 Subject: [PATCH 2/2] chagnelog entry --- experimental/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index e5f32d841e9..38ffb7d38b1 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -26,6 +26,7 @@ All notable changes to experimental packages in this project will be documented * fix(instrumentation-http): Ensure instrumentation of `http.get` and `https.get` work when used in ESM code [#4857](https://github.com/open-telemetry/opentelemetry-js/issues/4857) @trentm * fix(api-logs): align AnyValue to spec [#4893](https://github.com/open-telemetry/opentelemetry-js/pull/4893) @blumamir +* fix(instrumentation): remove diag.debug() message for instrumentations that do not patch modules [#4925](https://github.com/open-telemetry/opentelemetry-js/pull/4925) @trentm ### :books: (Refine Doc)