Skip to content

fix: bring http.request.header and http.response.header in line with … #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arielvalentin merged 1 commit into from
Jul 29, 2022
Merged

fix: bring http.request.header and http.response.header in line with … #111

arielvalentin merged 1 commit into from
Jul 29, 2022

Conversation

@scbjans
Copy link
Contributor

@scbjans scbjans commented Jul 29, 2022

…semantic conventions.

Fixes: #110

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 29, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

ahayworth
ahayworth approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@ahayworth ahayworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@ahayworth ahayworth mentioned this pull request Jul 29, 2022
Closed
@arielvalentin arielvalentin merged commit 1af9fc1 into open-telemetry:main Jul 29, 2022
@scbjans scbjans deleted the 110-http-header-semconv branch July 29, 2022 17:42
@scbjans scbjans mentioned this pull request Aug 3, 2023
Closed
6 tasks
@github-actions github-actions bot mentioned this pull request Jan 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arielvalentin arielvalentin arielvalentin approved these changes

@ahayworth ahayworth ahayworth approved these changes

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HTTP Header attribute name does not match semantic conventions

3 participants

@scbjans @arielvalentin @ahayworth