fix: Ensure Rack Events Handler Exists #519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #518
When attempting to use the Rack Events Handler via ActionPack, the install process raises the following error:
This is due to constant value shadowing occurring in the instrumentation namespace, where the defined check in require_dependencies is not searching the root namespace and is instead searching the OpenTelemetry::Instrumentation::Rack namespace:
This results in the Event Handler source not being loaded.