fix: Trilogy only set db.instance.id attribute if there is a value
#792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin and
simi
as code owners
arielvalentin
approved these changes
Jan 5, 2024
Contributor
Author
|
@arielvalentin I made one more tweak which is to only do a nil check. The ivar will always be defined because it's declared in |
jhawthorn
approved these changes
Jan 5, 2024
arielvalentin
added a commit
that referenced
this pull request
Jan 5, 2024
Closed
arielvalentin
added a commit
that referenced
this pull request
Jan 5, 2024
arielvalentin
changed the title
db.instance.id attribute if there is a valuedb.instance.id attribute if there is a value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for the
@connected_hostvalue to beunsetnilbecause a query is made within trilogy to initially assign the@connected_host:https://github.com/trilogy-libraries/trilogy/blob/3c3a3865a3896f3056b1d7c69c5244964b60937c/contrib/ruby/lib/trilogy.rb#L39-L50
This PR adds a presence check before assigning the attribute.