Skip to content

Add support for python 3.6 #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkterry1 merged 16 commits into from
May 25, 2022
Merged

Add support for python 3.6 #2836

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
02a52bd
Add support for python 3.6
pseudo-rnd-thoughts May 24, 2022
e99c220
Add support for python 3.6
pseudo-rnd-thoughts May 24, 2022
46b3a1c
Added check for python 3.6 to not install mujoco as no version exists
pseudo-rnd-thoughts May 24, 2022
7869668
Fixed the install groups for python 3.6
pseudo-rnd-thoughts May 24, 2022
41fe99e
Merge branch 'master' into support-py36
pseudo-rnd-thoughts May 25, 2022
dad339b
Re-added python 3.6 support for gym
pseudo-rnd-thoughts May 25, 2022
6d5f702
black
pseudo-rnd-thoughts May 25, 2022
6260f97
Added support for dataclasses through dataclasses module in setup tha…
pseudo-rnd-thoughts May 25, 2022
1941db8
Fixed install requirements
pseudo-rnd-thoughts May 25, 2022
5112324
Re-added dummy env spec with dataclasses
pseudo-rnd-thoughts May 25, 2022
ab56d3d
Merge branch 'master' into support-py36
pseudo-rnd-thoughts May 25, 2022
66ec6e9
Changed type for compatability for python 3.6
pseudo-rnd-thoughts May 25, 2022
4373163
Added a python 3.6 warning
pseudo-rnd-thoughts May 25, 2022
b8279b2
Fixed python 3.6 typing issue
pseudo-rnd-thoughts May 25, 2022
1517a4a
Removed __future__ import annotation for python 3.6 support
pseudo-rnd-thoughts May 25, 2022
430e935
Fixed python 3.6 typing
pseudo-rnd-thoughts May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added check for python 3.6 to not install mujoco as no version exists
  • Loading branch information
@pseudo-rnd-thoughts
pseudo-rnd-thoughts committed May 24, 2022
commit 46b3a1ca9511060d8668e6149f4367c60c646798
4 changes: 3 additions & 1 deletion py.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ ENV LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/root/.mujoco/mujoco210/bin
COPY . /usr/local/gym/
WORKDIR /usr/local/gym/

RUN pip install .[noatari] && pip install -r test_requirements.txt
Copy link
Contributor

@RedTachyon RedTachyon May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to specify that it has to be 3.6.15? I'm not sure what the reason for this is exactly, but I'm guessing this should apply to all 3.6.x versions

Copy link
Contributor Author

@pseudo-rnd-thoughts pseudo-rnd-thoughts May 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine because the python foundation is not releasing any more python versions and this dockerfile is only called by the CI which uses the latest version of each python, i.e. only python 3.6.15 will be used

RUN if [[ python:$PYTHON_VERSION == 3.6 ]] ; \
then pip install .[nomujoco] && pip install -r test_requirements.txt ; \
else pip install .[noatari] && pip install -r test_requirements.txt ; fi

ENTRYPOINT ["/usr/local/gym/bin/docker_entrypoint"]
1 change: 0 additions & 1 deletion test_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
lz4~=3.1
pytest~=6.2
pytest-forked~=1.3