diff --git a/api/src/main/java/org/openmrs/Form.java b/api/src/main/java/org/openmrs/Form.java index bc006cd9cf0f..a73cf28e8e0d 100644 --- a/api/src/main/java/org/openmrs/Form.java +++ b/api/src/main/java/org/openmrs/Form.java @@ -16,28 +16,52 @@ import java.util.List; import java.util.Set; +import jakarta.persistence.AttributeOverride; +import jakarta.persistence.CascadeType; +import jakarta.persistence.Column; +import jakarta.persistence.Entity; +import jakarta.persistence.FetchType; +import jakarta.persistence.GeneratedValue; +import jakarta.persistence.GenerationType; +import jakarta.persistence.Id; +import jakarta.persistence.JoinColumn; +import jakarta.persistence.ManyToOne; +import jakarta.persistence.OneToMany; +import jakarta.persistence.Table; + /** * Form * * @version 1.0 */ @Audited +@Entity +@Table(name = "form") +@AttributeOverride(name="description", column = @Column(name = "description", length = 1024)) public class Form extends BaseChangeableOpenmrsMetadata { public static final long serialVersionUID = 845634L; // Fields - + @Id + @GeneratedValue(strategy = GenerationType.IDENTITY) + @Column(name = "form_id") private Integer formId; - + + @Column(name = "version", nullable = false, length = 50) private String version; + @Column(name = "build", nullable = true) private Integer build; + @Column(name = "published", length = 1) private Boolean published = false; - + + @ManyToOne + @JoinColumn(name = "encounter_type") private EncounterType encounterType; - + + @OneToMany(mappedBy = "form", cascade = CascadeType.ALL, orphanRemoval = true, fetch = FetchType.LAZY) private Set formFields; // Constructors @@ -231,4 +255,4 @@ public void setId(Integer id) { setFormId(id); } -} +} \ No newline at end of file diff --git a/api/src/main/resources/hibernate.cfg.xml b/api/src/main/resources/hibernate.cfg.xml index 71c1b5f83e7e..4f86df809b49 100644 --- a/api/src/main/resources/hibernate.cfg.xml +++ b/api/src/main/resources/hibernate.cfg.xml @@ -32,7 +32,6 @@ - diff --git a/api/src/main/resources/org/openmrs/api/db/hibernate/Form.hbm.xml b/api/src/main/resources/org/openmrs/api/db/hibernate/Form.hbm.xml deleted file mode 100644 index 1e67c45288ab..000000000000 --- a/api/src/main/resources/org/openmrs/api/db/hibernate/Form.hbm.xml +++ /dev/null @@ -1,83 +0,0 @@ - - - - - - - - - - form_form_id_seq - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-1.9.x.xml b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-1.9.x.xml index 92311c463dbf..b4a5e90f5927 100644 --- a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-1.9.x.xml +++ b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-1.9.x.xml @@ -721,7 +721,7 @@ - + diff --git a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.1.x.xml b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.1.x.xml index da4732ed7efc..290ab20b0bac 100644 --- a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.1.x.xml +++ b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.1.x.xml @@ -1072,7 +1072,7 @@ - + diff --git a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.2.x.xml b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.2.x.xml index 10457f77ff26..45b8a9c8abab 100644 --- a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.2.x.xml +++ b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.2.x.xml @@ -1147,7 +1147,7 @@ - + diff --git a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.3.x.xml b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.3.x.xml index e4db8a95edd7..bda612f99bf1 100644 --- a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.3.x.xml +++ b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.3.x.xml @@ -1149,7 +1149,7 @@ - + diff --git a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.4.x.xml b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.4.x.xml index acd8077823c1..2951382f8fa3 100644 --- a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.4.x.xml +++ b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.4.x.xml @@ -1145,7 +1145,7 @@ - + diff --git a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.5.x.xml b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.5.x.xml index bdc637bfec25..e8dfa22a58a9 100644 --- a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.5.x.xml +++ b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.5.x.xml @@ -1205,7 +1205,7 @@ - + diff --git a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.6.x.xml b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.6.x.xml index 9370739daac7..7397ddafc5d8 100644 --- a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.6.x.xml +++ b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.6.x.xml @@ -1213,7 +1213,7 @@ - + diff --git a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.7.x.xml b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.7.x.xml index 61692a8709b8..1264b3e35d49 100644 --- a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.7.x.xml +++ b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.7.x.xml @@ -1235,7 +1235,7 @@ - + diff --git a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.8.x.xml b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.8.x.xml index f1f80fc13072..39ef44d57544 100644 --- a/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.8.x.xml +++ b/api/src/main/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-2.8.x.xml @@ -1235,7 +1235,7 @@ - + diff --git a/api/src/main/resources/org/openmrs/liquibase/updates/liquibase-update-to-latest-2.0.x.xml b/api/src/main/resources/org/openmrs/liquibase/updates/liquibase-update-to-latest-2.0.x.xml index c666a2095dc1..945f8b0939d6 100644 --- a/api/src/main/resources/org/openmrs/liquibase/updates/liquibase-update-to-latest-2.0.x.xml +++ b/api/src/main/resources/org/openmrs/liquibase/updates/liquibase-update-to-latest-2.0.x.xml @@ -305,7 +305,7 @@ - + + + + + + Rename retired_reason to retire_reason for consistency + + + diff --git a/api/src/test/java/org/openmrs/api/OrderServiceTest.java b/api/src/test/java/org/openmrs/api/OrderServiceTest.java index da44bdd89565..91890a1204aa 100644 --- a/api/src/test/java/org/openmrs/api/OrderServiceTest.java +++ b/api/src/test/java/org/openmrs/api/OrderServiceTest.java @@ -44,6 +44,7 @@ import org.openmrs.DrugOrder; import org.openmrs.Encounter; import org.openmrs.EncounterRole; +import org.openmrs.Form; import org.openmrs.FreeTextDosingInstructions; import org.openmrs.GlobalProperty; import org.openmrs.Location; @@ -2787,6 +2788,7 @@ public void saveOrder_shouldFailIfTheJavaTypeOfThePreviousOrderDoesNotMatch() th .addAnnotatedClass(ConceptNameTag.class) .addAnnotatedClass(CareSetting.class) .addAnnotatedClass(LocationTag.class) + .addAnnotatedClass(Form.class) .getMetadataBuilder().build(); diff --git a/api/src/test/java/org/openmrs/util/DatabaseUpdaterDatabaseIT.java b/api/src/test/java/org/openmrs/util/DatabaseUpdaterDatabaseIT.java index 092b59c49b5e..2a2aadbba3ad 100644 --- a/api/src/test/java/org/openmrs/util/DatabaseUpdaterDatabaseIT.java +++ b/api/src/test/java/org/openmrs/util/DatabaseUpdaterDatabaseIT.java @@ -32,7 +32,7 @@ public class DatabaseUpdaterDatabaseIT extends DatabaseIT { * This constant needs to be updated when adding new Liquibase update files to openmrs-core. */ - private static final int CHANGE_SET_COUNT_FOR_GREATER_THAN_2_1_X = 905; + private static final int CHANGE_SET_COUNT_FOR_GREATER_THAN_2_1_X = 906; private static final int CHANGE_SET_COUNT_FOR_2_1_X = 870; diff --git a/api/src/test/resources/org/openmrs/api/db/hibernate/include/HibernateFormDAOTestDataSet.xml b/api/src/test/resources/org/openmrs/api/db/hibernate/include/HibernateFormDAOTestDataSet.xml index 7e662eec791a..a9b62cd9cdac 100644 --- a/api/src/test/resources/org/openmrs/api/db/hibernate/include/HibernateFormDAOTestDataSet.xml +++ b/api/src/test/resources/org/openmrs/api/db/hibernate/include/HibernateFormDAOTestDataSet.xml @@ -15,11 +15,11 @@ -
- - - - + + + + + diff --git a/api/src/test/resources/org/openmrs/api/include/FormServiceTest-formFields.xml b/api/src/test/resources/org/openmrs/api/include/FormServiceTest-formFields.xml index 442471e81e3d..3ef93187406e 100644 --- a/api/src/test/resources/org/openmrs/api/include/FormServiceTest-formFields.xml +++ b/api/src/test/resources/org/openmrs/api/include/FormServiceTest-formFields.xml @@ -14,7 +14,7 @@ - + diff --git a/api/src/test/resources/org/openmrs/api/include/FormServiceTest-multipleForms-formFields.xml b/api/src/test/resources/org/openmrs/api/include/FormServiceTest-multipleForms-formFields.xml index 2b551b1c90cf..6d489587e3c0 100644 --- a/api/src/test/resources/org/openmrs/api/include/FormServiceTest-multipleForms-formFields.xml +++ b/api/src/test/resources/org/openmrs/api/include/FormServiceTest-multipleForms-formFields.xml @@ -14,17 +14,17 @@ - + - + - - + + diff --git a/api/src/test/resources/org/openmrs/hl7/include/ORUTest-initialData.xml b/api/src/test/resources/org/openmrs/hl7/include/ORUTest-initialData.xml index 9bd4767e1d69..3b35e8de369d 100644 --- a/api/src/test/resources/org/openmrs/hl7/include/ORUTest-initialData.xml +++ b/api/src/test/resources/org/openmrs/hl7/include/ORUTest-initialData.xml @@ -84,11 +84,11 @@ - - - - - - + + + + + + diff --git a/api/src/test/resources/org/openmrs/include/standardTestDataset.xml b/api/src/test/resources/org/openmrs/include/standardTestDataset.xml index 77b0acf426a8..a485d30a5964 100644 --- a/api/src/test/resources/org/openmrs/include/standardTestDataset.xml +++ b/api/src/test/resources/org/openmrs/include/standardTestDataset.xml @@ -313,7 +313,7 @@ - + diff --git a/api/src/test/resources/org/openmrs/util/databasechange/standardTest-1.9.7-dataSet.xml b/api/src/test/resources/org/openmrs/util/databasechange/standardTest-1.9.7-dataSet.xml index 4b5dd88a5dd4..515698e872ee 100644 --- a/api/src/test/resources/org/openmrs/util/databasechange/standardTest-1.9.7-dataSet.xml +++ b/api/src/test/resources/org/openmrs/util/databasechange/standardTest-1.9.7-dataSet.xml @@ -254,7 +254,7 @@ - + diff --git a/initial_test_db.sql b/initial_test_db.sql index 8bc50aa8ee7a..b89d9eab89d6 100644 --- a/initial_test_db.sql +++ b/initial_test_db.sql @@ -1823,7 +1823,7 @@ CREATE TABLE `form` ( `retired` tinyint(1) NOT NULL DEFAULT 0, `retired_by` int(11) DEFAULT NULL, `date_retired` datetime DEFAULT NULL, - `retired_reason` varchar(255) DEFAULT NULL, + `retire_reason` varchar(255) DEFAULT NULL, `uuid` char(38) NOT NULL, PRIMARY KEY (`form_id`), UNIQUE KEY `uuid_form` (`uuid`), diff --git a/liquibase/src/test/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-SNAPSHOT.xml b/liquibase/src/test/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-SNAPSHOT.xml index 11e5bee4c06b..db6d8f600ecf 100644 --- a/liquibase/src/test/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-SNAPSHOT.xml +++ b/liquibase/src/test/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-SNAPSHOT.xml @@ -1235,7 +1235,7 @@ - + diff --git a/liquibase/src/test/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-UPDATED-SNAPSHOT.xml b/liquibase/src/test/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-UPDATED-SNAPSHOT.xml index 96a6e56e8c9a..b02382fba21e 100644 --- a/liquibase/src/test/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-UPDATED-SNAPSHOT.xml +++ b/liquibase/src/test/resources/org/openmrs/liquibase/snapshots/schema-only/liquibase-schema-only-UPDATED-SNAPSHOT.xml @@ -1235,7 +1235,7 @@ - +