Skip to content

Core 1079 port adoption and interest pages to ts #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 11, 2025
Merged

Core 1079 port adoption and interest pages to ts #2763

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f3e67ad
Adoption & Interest pages
RoyEJohnson Aug 1, 2025
e545c02
General page
RoyEJohnson Aug 1, 2025
71cbd61
Cover partners page filter-remover
RoyEJohnson Aug 1, 2025
b64da58
General page test coverage
RoyEJohnson Aug 1, 2025
20c0da6
adoption and interest tests
RoyEJohnson Aug 4, 2025
8e3f53e
Make role-selector test less flaky
RoyEJohnson Aug 4, 2025
1d92257
Prettier
RoyEJohnson Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cover partners page filter-remover
  • Loading branch information
@RoyEJohnson
RoyEJohnson committed Aug 6, 2025
commit 71cbd61111511ae2baf06aa56f05b74a6e138e3d
3 changes: 3 additions & 0 deletions test/src/pages/partners/partners.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,10 +311,13 @@ describe('partners full page', () => {
);

const buttons = screen.getAllByRole('checkbox');
const label = buttons[0].getAttribute('aria-label');
Copy link
Contributor Author

@RoyEJohnson RoyEJohnson Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little Partner page functionality that didn't have test coverage: filter remover


await user.click(buttons[0]);
await user.click(await screen.findByRole('button', {name: 'close'}));
await screen.findByRole('button', {name: 'Filters (1)'});
await user.click(screen.getByRole('button', {name: `remove filter for ${label}`}));
expect(screen.queryByRole('button', {name: `remove filter for ${label}`})).toBeNull();
});
// This one has to be last; something doesn't reset
it('uses default infoLinkText when none is provided', async () => {
Expand Down