Skip to content

(fix): get_variation input validation fixes. #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2020
Merged

(fix): get_variation input validation fixes. #441

merged 1 commit into from
Jan 13, 2020

Conversation

@yasirfolio3
Copy link
Contributor

@yasirfolio3 yasirfolio3 commented Jan 13, 2020 •
edited by msohailhussain
Loading

Summary

  • Fixed issue for experimentKey and user_id validation for get_variation.
  • Notification was fired in every getVariation case where experimentKey was invalid.

TestPlan

@coveralls
Copy link

coveralls commented Jan 13, 2020

Coverage Status

Coverage increased (+29.7%) to 98.112% when pulling 4593161 on yasir/get-variation-fix into 138fff5 on master.

@yasirfolio3 yasirfolio3 changed the title (fix): get_variation input validation fixes. DO NOT REVIEW (fix): get_variation input validation fixes. Jan 13, 2020
@msohailhussain msohailhussain marked this pull request as ready for review January 13, 2020 19:23
@msohailhussain msohailhussain requested a review from a team as a code owner January 13, 2020 19:23
@msohailhussain msohailhussain changed the title DO NOT REVIEW (fix): get_variation input validation fixes. (fix): get_variation input validation fixes. Jan 13, 2020
jaeopt
jaeopt approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 65c078b into master Jan 13, 2020
@jaeopt jaeopt deleted the yasir/get-variation-fix branch January 13, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yasirfolio3 @coveralls @jaeopt