Merge pull request aputinski#7 from matthinz/unmounting-fix

Fix "undefined is not an object" in componentWillUnmount

Author: aputinski

spec/navigation-controller.spec.jsx

@@ -76,6 +76,24 @@ describe('NavigationController', () => {
       expect(controller.__springSystem).to.be.an.instanceof(rebound.SpringSystem);
     });
   });
+  describe('#componentWillUnmount', () => {
+    let spring;
+    beforeEach(() => {
+      controller = new NavigationController({ views: views });
+      controller.componentWillMount();
+      spring = controller.__spring;
+      controller.componentWillUnmount();
+    })
+    it('cleans up spring system', () => {
+      expect(controller.__springSystem).to.be.undefined
+    });
+    it('cleans up spring', () => {
+      expect(controller.__spring).to.be.undefined
+    });
+    it('removes spring event listeners', () => {
+      expect(spring.listeners).to.deep.equal([]);
+    });
+  });
   describe('#componentDidMount', () => {
     it('caches the view wrappers', () => {
       expect(viewWrapper0).to.be.an.instanceof(HTMLElement);

src/navigation-controller.jsx

@@ -112,6 +112,12 @@ class NavigationController extends React.Component {
     });
   }
 
+  componentWillUnmount() {
+    delete this.__springSystem;
+    this.__spring.removeAllListeners();
+    delete this.__spring;
+  }
+
   componentDidMount() {
     // Cache the view wrappers
     this['__view-wrapper-0'] = React.findDOMNode(this.refs[`view-wrapper-0`]);
@@ -124,10 +130,6 @@ class NavigationController extends React.Component {
     });
   }
 
-  componentWillUnmount() {
-    this.__viewSpring.destroy();
-  }
-
   /**
    * Translate the view wrappers by a specified percentage
    *