From 3726546101525a8d91ea373933b45271bbb5476f Mon Sep 17 00:00:00 2001 From: Alan Maguire Date: Tue, 12 Dec 2023 13:00:10 +0000 Subject: [PATCH] change netns logging to debug-only, make fib6_age optional in former case, logs were too noisy as netns creation/destruction is very frequent, in latter case fib6_age is inlined/missing on upstream kernels. Signed-off-by: Alan Maguire --- src/netns_tuner.c | 10 +++++----- src/route_table_tuner.c | 4 +++- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/netns_tuner.c b/src/netns_tuner.c index c777e09..bcc83a5 100644 --- a/src/netns_tuner.c +++ b/src/netns_tuner.c @@ -100,9 +100,9 @@ void event_handler(__attribute__((unused))struct bpftuner *tuner, default: return; } - bpftuner_tunable_update(tuner, NETNS, event->scenario_id, netns_fd, - "netns %s (cookie %ld)\n", - event->scenario_id == NETNS_SCENARIO_CREATE ? - "created" : "destroyed", - event->netns_cookie); + /* use debug logging as these events are very frequent. */ + bpftune_log(LOG_DEBUG, "netns %s (cookie %ld)\n", + event->scenario_id == NETNS_SCENARIO_CREATE ? + "created" : "destroyed", + event->netns_cookie); } diff --git a/src/route_table_tuner.c b/src/route_table_tuner.c index e372a57..268b0ce 100644 --- a/src/route_table_tuner.c +++ b/src/route_table_tuner.c @@ -39,7 +39,9 @@ static struct bpftunable_scenario scenarios[] = { int init(struct bpftuner *tuner) { - int err = bpftuner_bpf_init(route_table, tuner, NULL); + const char *optionals[] = { "entry__fib6_age", NULL }; + + int err = bpftuner_bpf_init(route_table, tuner, optionals); if (err) return err;