diff --git a/config/config.sample.php b/config/config.sample.php index 44dc91b47899..a1eb92034b65 100644 --- a/config/config.sample.php +++ b/config/config.sample.php @@ -689,11 +689,6 @@ * Options for the Apps folder, Apps store, and App code checker. */ -/** - * When enabled, admins may install apps from the ownCloud app store. - */ -'appstoreenabled' => true, - /** * The URL of the appstore to use. */ diff --git a/lib/private/legacy/app.php b/lib/private/legacy/app.php index 7ef96b108764..0fc76439fcab 100644 --- a/lib/private/legacy/app.php +++ b/lib/private/legacy/app.php @@ -521,10 +521,6 @@ private static function proceedNavigation($list) { * @return string|false */ public static function getInstallPath() { - if (\OC::$server->getSystemConfig()->getValue('appstoreenabled', true) == false) { - return false; - } - foreach (OC::$APPSROOTS as $dir) { if (isset($dir['writable']) && $dir['writable'] === true) { return $dir['path']; diff --git a/lib/private/legacy/util.php b/lib/private/legacy/util.php index ecee9f1ec71c..3b000265e33d 100644 --- a/lib/private/legacy/util.php +++ b/lib/private/legacy/util.php @@ -727,19 +727,17 @@ public static function checkServer(\OCP\IConfig $config) { } // Check if there is a writable install folder. - if ($config->getSystemValue('appstoreenabled', true)) { - if (OC_App::getInstallPath() === null - || !is_writable(OC_App::getInstallPath()) - || !is_readable(OC_App::getInstallPath()) - ) { - $errors[] = [ - 'error' => $l->t('Cannot write into "apps" directory'), - 'hint' => $l->t('This can usually be fixed by ' - . '%sgiving the webserver write access to the apps directory%s' - . ' or disabling the appstore in the config file.', - ['', '']) - ]; - } + if (OC_App::getInstallPath() === null + || !is_writable(OC_App::getInstallPath()) + || !is_readable(OC_App::getInstallPath()) + ) { + $errors[] = [ + 'error' => $l->t('Cannot write into "apps" directory'), + 'hint' => $l->t('This can usually be fixed by ' + . '%sgiving the webserver write access to the apps directory%s' + . ' or disabling the appstore in the config file.', + ['', '']) + ]; } // Create root dir. if ($config->getSystemValue('installed', false)) { diff --git a/settings/Controller/CheckSetupController.php b/settings/Controller/CheckSetupController.php index 250ed74377db..765e857ab532 100644 --- a/settings/Controller/CheckSetupController.php +++ b/settings/Controller/CheckSetupController.php @@ -147,24 +147,16 @@ protected function getCurlVersion() { * @return string */ private function isUsedTlsLibOutdated() { - // Appstore is disabled by default in EE - $appStoreDefault = false; - if (\OC_Util::getEditionString() === \OC_Util::EDITION_COMMUNITY) { - $appStoreDefault = true; - } - // Don't run check when: // 1. Server has `has_internet_connection` set to false // 2. AppStore AND S2S is disabled if(!$this->config->getSystemValue('has_internet_connection', true)) { return ''; } - if(!$this->config->getSystemValue('appstoreenabled', $appStoreDefault) - && $this->config->getAppValue('files_sharing', 'outgoing_server2server_share_enabled', 'yes') === 'no' + if($this->config->getAppValue('files_sharing', 'outgoing_server2server_share_enabled', 'yes') === 'no' && $this->config->getAppValue('files_sharing', 'incoming_server2server_share_enabled', 'yes') === 'no') { return ''; } - $versionString = $this->getCurlVersion(); if(isset($versionString['ssl_version'])) { $versionString = $versionString['ssl_version']; @@ -172,10 +164,7 @@ private function isUsedTlsLibOutdated() { return ''; } - $features = (string)$this->l10n->t('installing and updating apps via the app store or Federated Cloud Sharing'); - if(!$this->config->getSystemValue('appstoreenabled', $appStoreDefault)) { - $features = (string)$this->l10n->t('Federated Cloud Sharing'); - } + $features = (string)$this->l10n->t('installing and updating apps via the market or Federated Cloud Sharing'); // Check if at least OpenSSL after 1.01d or 1.0.2b if(strpos($versionString, 'OpenSSL/') === 0) { diff --git a/settings/Panels/Admin/Apps.php b/settings/Panels/Admin/Apps.php index 5a7e7b03c561..3cf54c69150a 100644 --- a/settings/Panels/Admin/Apps.php +++ b/settings/Panels/Admin/Apps.php @@ -45,7 +45,6 @@ public function getPriority() { public function getPanel() { $tmpl = new Template('settings', 'panels/admin/apps'); - $tmpl->assign('appstoreEnabled', $this->config->getSystemValue('appstoreenabled', true)); return $tmpl; } @@ -53,4 +52,4 @@ public function getSectionID() { return 'apps'; } -} \ No newline at end of file +} diff --git a/settings/templates/panels/admin/apps.php b/settings/templates/panels/admin/apps.php index b9370694c288..65927747342d 100644 --- a/settings/templates/panels/admin/apps.php +++ b/settings/templates/panels/admin/apps.php @@ -16,11 +16,9 @@ {{/each}} - -
  • - t('Developer documentation'));?> ↗ -
  • - +
  • + t('Developer documentation'));?> ↗ +