-
-
Notifications
You must be signed in to change notification settings - Fork 867
Expand file tree
/
Copy pathno_unescaped_entities.rs
More file actions
186 lines (175 loc) · 4.91 KB
/
no_unescaped_entities.rs
File metadata and controls
186 lines (175 loc) · 4.91 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
use oxc_ast::AstKind;
use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint;
use oxc_span::Span;
use crate::{
AstNode,
context::{ContextHost, LintContext},
rule::Rule,
};
static ESCAPED_DOUBLE_QUOTE: &str = "" or “ or " or ”";
static ESCAPED_SINGLE_QUOTE: &str = "' or ‘ or ' or ’";
fn no_unescaped_entities_diagnostic(span: Span, unescaped: char) -> OxcDiagnostic {
let escaped = if unescaped == '"' { ESCAPED_DOUBLE_QUOTE } else { ESCAPED_SINGLE_QUOTE };
OxcDiagnostic::warn(format!("`{unescaped}` can be escaped with {escaped}")).with_label(span)
}
#[derive(Debug, Default, Clone)]
pub struct NoUnescapedEntities;
declare_oxc_lint!(
/// ### What it does
///
/// This rule prevents characters that you may have meant as JSX escape characters from being accidentally injected as a text node in JSX statements.
///
/// ### Why is this bad?
///
/// JSX escape characters are used to inject characters into JSX statements that would otherwise be interpreted as code.
///
/// ### Example
/// Incorrect
///
/// ```jsx
/// <div> > </div>
/// ```
///
/// Correct
///
/// ```jsx
/// <div> > </div>
/// ```
///
/// ```jsx
/// <div> {'>'} </div>
/// ```
NoUnescapedEntities,
react,
pedantic
);
impl Rule for NoUnescapedEntities {
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
if let AstKind::JSXText(jsx_text) = node.kind() {
let source = jsx_text.raw.unwrap().as_str();
for (i, &byte) in source.as_bytes().iter().enumerate() {
if matches!(byte, b'\'' | b'\"') {
#[expect(clippy::cast_possible_truncation)]
let start = jsx_text.span.start + i as u32;
ctx.diagnostic(no_unescaped_entities_diagnostic(
Span::new(start, start + 1),
byte as char,
));
}
}
}
}
fn should_run(&self, ctx: &ContextHost) -> bool {
ctx.source_type().is_jsx()
}
}
#[test]
fn test() {
use crate::tester::Tester;
let pass = vec![
"
var Hello = createReactClass({
render: function() {
return (
<div/>
);
}
});
",
"
var Hello = createReactClass({
render: function() {
return <div>Here is some text!</div>;
}
});
",
"
var Hello = createReactClass({
render: function() {
return <div>I’ve escaped some entities: > < &</div>;
}
});
",
"
var Hello = createReactClass({
render: function() {
return <div>first line is ok
so is second
and here are some escaped entities: > < &</div>;
}
});
",
"
var Hello = createReactClass({
render: function() {
return <div>{\">\" + \"<\" + \"&\" + '\"'}</div>;
},
});
",
"
var Hello = createReactClass({
render: function() {
return <>Here is some text!</>;
}
});
",
"
var Hello = createReactClass({
render: function() {
return <>I’ve escaped some entities: > < &</>;
}
});
",
"
var Hello = createReactClass({
render: function() {
return <>{\">\" + \"<\" + \"&\" + '\"'}</>;
},
});
",
];
let fail = vec![
"var Hello = createReactClass({
render: function() {
return <>> babel-eslint</>;
}
});",
"var Hello = createReactClass({
render: function() {
return <>first line is ok
so is second
and here are some bad entities: ></>
}
});",
"
var Hello = createReactClass({
render: function() {
return <div>'</div>;
}
});
",
r#"
var Hello = createReactClass({
render: function() {
return <>{"Unbalanced braces - babel-eslint"}}</>;
}
});
"#,
// "var Hello = createReactClass({
// render: function() {
// return <>foo & bar</>;
// }
// });",
// " var Hello = createReactClass({
// render: function() {
// return <span>foo & bar</span>;
// }
// });
// ",
r#"<script>window.foo = "bar"</script>"#,
r#"<script>测试 " 测试</script>"#,
];
Tester::new(NoUnescapedEntities::NAME, NoUnescapedEntities::PLUGIN, pass, fail)
.test_and_snapshot();
}