Skip to content

Commit b7c4688

Browse files
committed
refactor(minifier): use ctx.ast.vec instead of Vec::new
1 parent f9ae70c commit b7c4688

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

crates/oxc_minifier/src/ast_passes/peephole_substitute_alternate_syntax.rs

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ impl<'a> PeepholeSubstituteAlternateSyntax {
358358
if new_expr.arguments.is_empty()
359359
&& new_expr.callee.is_global_reference_name("Object", ctx.symbols())
360360
{
361-
Some(ctx.ast.expression_object(new_expr.span, Vec::new_in(ctx.ast.allocator), None))
361+
Some(ctx.ast.expression_object(new_expr.span, ctx.ast.vec(), None))
362362
} else if new_expr.callee.is_global_reference_name("Array", ctx.symbols()) {
363363
// `new Array` -> `[]`
364364
if new_expr.arguments.is_empty() {
@@ -377,7 +377,7 @@ impl<'a> PeepholeSubstituteAlternateSyntax {
377377
}
378378
// `new Array(literal)` -> `[literal]`
379379
else if arg.is_literal() || matches!(arg, Expression::ArrayExpression(_)) {
380-
let mut elements = Vec::new_in(ctx.ast.allocator);
380+
let mut elements = ctx.ast.vec();
381381
let element =
382382
ctx.ast.array_expression_element_expression(ctx.ast.move_expression(arg));
383383
elements.push(element);
@@ -391,14 +391,13 @@ impl<'a> PeepholeSubstituteAlternateSyntax {
391391
}
392392
} else {
393393
// `new Array(1, 2, 3)` -> `[1, 2, 3]`
394-
let elements = Vec::from_iter_in(
394+
let elements = ctx.ast.vec_from_iter(
395395
new_expr.arguments.iter_mut().filter_map(|arg| arg.as_expression_mut()).map(
396396
|arg| {
397397
ctx.ast
398398
.array_expression_element_expression(ctx.ast.move_expression(arg))
399399
},
400400
),
401-
ctx.ast.allocator,
402401
);
403402
Some(self.array_literal(elements, ctx))
404403
}
@@ -416,7 +415,7 @@ impl<'a> PeepholeSubstituteAlternateSyntax {
416415
if call_expr.arguments.is_empty()
417416
&& call_expr.callee.is_global_reference_name("Object", ctx.symbols())
418417
{
419-
Some(ctx.ast.expression_object(call_expr.span, Vec::new_in(ctx.ast.allocator), None))
418+
Some(ctx.ast.expression_object(call_expr.span, ctx.ast.vec(), None))
420419
} else if call_expr.callee.is_global_reference_name("Array", ctx.symbols()) {
421420
// `Array()` -> `[]`
422421
if call_expr.arguments.is_empty() {
@@ -438,7 +437,7 @@ impl<'a> PeepholeSubstituteAlternateSyntax {
438437
}
439438
// `Array(literal)` -> `[literal]`
440439
else if arg.is_literal() || matches!(arg, Expression::ArrayExpression(_)) {
441-
let mut elements = Vec::new_in(ctx.ast.allocator);
440+
let mut elements = ctx.ast.vec();
442441
let element =
443442
ctx.ast.array_expression_element_expression(ctx.ast.move_expression(arg));
444443
elements.push(element);
@@ -448,14 +447,13 @@ impl<'a> PeepholeSubstituteAlternateSyntax {
448447
}
449448
} else {
450449
// `Array(1, 2, 3)` -> `[1, 2, 3]`
451-
let elements = Vec::from_iter_in(
450+
let elements = ctx.ast.vec_from_iter(
452451
call_expr.arguments.iter_mut().filter_map(|arg| arg.as_expression_mut()).map(
453452
|arg| {
454453
ctx.ast
455454
.array_expression_element_expression(ctx.ast.move_expression(arg))
456455
},
457456
),
458-
ctx.ast.allocator,
459457
);
460458
Some(self.array_literal(elements, ctx))
461459
}
@@ -485,7 +483,7 @@ impl<'a> PeepholeSubstituteAlternateSyntax {
485483

486484
/// returns a new empty array literal expression: `[]`
487485
fn empty_array_literal(&self, ctx: &mut TraverseCtx<'a>) -> Expression<'a> {
488-
self.array_literal(Vec::new_in(ctx.ast.allocator), ctx)
486+
self.array_literal(ctx.ast.vec(), ctx)
489487
}
490488
}
491489

0 commit comments

Comments
 (0)