refactor(rust): remove usages of lazy_static (#10007)

Author: Boshen

Cargo.lock

@@ -226,7 +226,7 @@ ureq = { version = "3.0.5", default-features = false }
 walkdir = "2.5.0"
 
 [workspace.metadata.cargo-shear]
-ignored = ["napi", "oxc_transform_napi", "oxc_parser_napi", "prettyplease"]
+ignored = ["napi", "oxc_transform_napi", "oxc_parser_napi", "prettyplease", "lazy_static"]
 
 [profile.dev]
 # Disabling debug info speeds up local and CI builds,

Cargo.toml

@@ -1,13 +1,15 @@
-use std::sync::Mutex;
+use std::sync::{
+    OnceLock, {RwLock, RwLockWriteGuard},
+};
 
 use lazy_regex::Regex;
-use lazy_static::lazy_static;
+use rustc_hash::{FxHashMap, FxHashSet};
+use serde::Deserialize;
+
 use oxc_ast::{AstKind, ast::MethodDefinitionKind};
 use oxc_diagnostics::{LabeledSpan, OxcDiagnostic};
 use oxc_macros::declare_oxc_lint;
 use oxc_semantic::{AstNode, JSDoc};
-use rustc_hash::{FxHashMap, FxHashSet};
-use serde::Deserialize;
 
 use crate::{
     context::LintContext,
@@ -91,9 +93,9 @@ fn default_check_types_pattern() -> String {
     "^(?:[oO]bject|[aA]rray|PlainObject|Generic(?:Object|Array))$".to_string() // spellchecker:disable-line
 }
 
-// For perf, cache regex is needed
-lazy_static! {
-    static ref REGEX_CACHE: Mutex<FxHashMap<String, Regex>> = Mutex::new(FxHashMap::default());
+fn regex_cache() -> RwLockWriteGuard<'static, FxHashMap<String, Regex>> {
+    static REGEX_CACHE: OnceLock<RwLock<FxHashMap<String, Regex>>> = OnceLock::new();
+    REGEX_CACHE.get_or_init(|| RwLock::new(FxHashMap::default())).write().unwrap()
 }
 
 impl Rule for RequireParam {
@@ -165,9 +167,9 @@ impl Rule for RequireParam {
         let shallow_tags =
             tags_to_check.iter().filter(|(name, _)| !name.contains('.')).collect::<Vec<_>>();
 
-        let mut regex_cache = REGEX_CACHE.lock().unwrap();
+        let mut cache = regex_cache();
         let check_types_regex =
-            regex_cache.entry(config.check_types_pattern.clone()).or_insert_with(|| {
+            cache.entry(config.check_types_pattern.clone()).or_insert_with(|| {
                 Regex::new(config.check_types_pattern.as_str())
                     .expect("`config.checkTypesPattern` should be a valid regex pattern")
             });

crates/oxc_linter/src/rules/jsdoc/require_param.rs

@@ -1,4 +1,3 @@
-use lazy_static::lazy_static;
 use phf::phf_map;
 
 use oxc_ast::{
@@ -80,16 +79,14 @@ impl PreferTagOverRole {
     }
 }
 
-lazy_static! {
-    static ref ROLE_TO_TAG_MAP: phf::Map<&'static str, &'static str> = phf_map! {
-        "checkbox" => "input",
-        "button" => "button",
-        "heading" => "h1,h2,h3,h4,h5,h6",
-        "link" => "a,area",
-        "rowgroup" => "tbody,tfoot,thead",
-        "banner" => "header",
-    };
-}
+const ROLE_TO_TAG_MAP: phf::Map<&'static str, &'static str> = phf_map! {
+    "checkbox" => "input",
+    "button" => "button",
+    "heading" => "h1,h2,h3,h4,h5,h6",
+    "link" => "a,area",
+    "rowgroup" => "tbody,tfoot,thead",
+    "banner" => "header",
+};
 
 impl Rule for PreferTagOverRole {
     fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {

crates/oxc_linter/src/rules/jsx_a11y/prefer_tag_over_role.rs

@@ -1,8 +1,7 @@
-use std::borrow::Cow;
+use std::{borrow::Cow, sync::OnceLock};
 
 use cow_utils::CowUtils;
 use itertools::Itertools;
-use lazy_static::lazy_static;
 use oxc_ast::{
     AstKind,
     ast::{JSXAttributeItem, JSXAttributeName, JSXElementName},
@@ -426,12 +425,15 @@ const DOM_PROPERTIES_IGNORE_CASE: [&str; 5] = [
     "webkitDirectory",
 ];
 
-lazy_static! {
-    static ref DOM_PROPERTIES_LOWER_MAP: FxHashMap<Cow<'static, str>, &'static str> =
+fn dom_properties_lower_map() -> &'static FxHashMap<Cow<'static, str>, &'static str> {
+    static DOM_PROPERTIES_LOWER_MAP: OnceLock<FxHashMap<Cow<'static, str>, &'static str>> =
+        OnceLock::new();
+    DOM_PROPERTIES_LOWER_MAP.get_or_init(|| {
         DOM_PROPERTIES_NAMES
             .iter()
             .map(|it| (it.cow_to_ascii_lowercase(), *it))
-            .collect::<FxHashMap<_, _>>();
+            .collect::<FxHashMap<_, _>>()
+    })
 }
 
 /// Checks if an attribute name is a valid `data-*` attribute:
@@ -544,7 +546,7 @@ impl Rule for NoUnknownProperty {
                     return;
                 }
 
-                DOM_PROPERTIES_LOWER_MAP
+                dom_properties_lower_map()
                     .get(&name.cow_to_ascii_lowercase())
                     .or_else(|| DOM_ATTRIBUTES_TO_CAMEL.get(name))
                     .map_or_else(

crates/oxc_linter/src/rules/react/no_unknown_property.rs

@@ -33,7 +33,6 @@ encoding_rs = { workspace = true }
 encoding_rs_io = { workspace = true }
 futures = { workspace = true }
 lazy-regex = { workspace = true }
-lazy_static = { workspace = true }
 pico-args = { workspace = true }
 rayon = { workspace = true }
 rustc-hash = { workspace = true }

tasks/coverage/Cargo.toml

@@ -2,7 +2,7 @@
 
 use std::{fs, path::Path, sync::Arc};
 
-use lazy_regex::Regex;
+use lazy_regex::{Lazy, Regex, lazy_regex};
 use rustc_hash::FxHashMap;
 
 use oxc::{
@@ -15,11 +15,11 @@ use oxc::{
 
 use crate::workspace_root;
 
-lazy_static::lazy_static! {
-    // Returns a match for a test option. Test options have the form `// @name: value`
-    static ref META_OPTIONS: Regex = Regex::new(r"(?m)^/{2}[[:space:]]*@(?P<name>[[:word:]]+)[[:space:]]*:[[:space:]]*(?P<value>[^\r\n]*)").unwrap();
-    static ref TEST_BRACES: Regex = Regex::new(r"^[[:space:]]*[{|}][[:space:]]*$").unwrap();
-}
+// Returns a match for a test option. Test options have the form `// @name: value`
+static META_OPTIONS: Lazy<Regex> = lazy_regex!(
+    r"(?m)^/{2}[[:space:]]*@(?P<name>[[:word:]]+)[[:space:]]*:[[:space:]]*(?P<value>[^\r\n]*)"
+);
+// static TEST_BRACES: Lazy<Regex> = lazy_regex!(r"^[[:space:]]*[{|}][[:space:]]*$");
 
 #[expect(unused)]
 #[derive(Debug)]