Merge pull request kubernetes-sigs#530 from mengqiy/tmpdir

k8s-ci-robot · web-flow · commit f770dcbeee28 · 2019-07-23T18:58:14.000-07:00
🐛 stop using hardcoded temp dir
diff --git a/pkg/webhook/server.go b/pkg/webhook/server.go
@@ -22,7 +22,7 @@ import (
 	"fmt"
 	"net"
 	"net/http"
-	"path"
+	"os"
 	"path/filepath"
 	"strconv"
 	"sync"
@@ -85,7 +85,7 @@ func (s *Server) setDefaults() {
 	}
 
 	if len(s.CertDir) == 0 {
-		s.CertDir = path.Join("/tmp", "k8s-webhook-server", "serving-certs")
+		s.CertDir = filepath.Join(os.TempDir(), "k8s-webhook-server", "serving-certs")
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ import (`
`22`	`22`	`"fmt"`
`23`	`23`	`"net"`
`24`	`24`	`"net/http"`
`25`		`- "path"`
	`25`	`+ "os"`
`26`	`26`	`"path/filepath"`
`27`	`27`	`"strconv"`
`28`	`28`	`"sync"`
`@@ -85,7 +85,7 @@ func (s *Server) setDefaults() {`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`if len(s.CertDir) == 0 {`
`88`		`- s.CertDir = path.Join("/tmp", "k8s-webhook-server", "serving-certs")`
	`88`	`+ s.CertDir = filepath.Join(os.TempDir(), "k8s-webhook-server", "serving-certs")`
`89`	`89`	`}`
`90`	`90`	`}`
`91`	`91`