Skip to content

DEPR: method, limit, fill_axis keywords in align #51968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phofl merged 6 commits into from
Mar 16, 2023
+105 −26
Merged

DEPR: method, limit, fill_axis keywords in align #51968

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d9d518d
DEPR: method, limit, fill_axis keywords in align
jbrockmendel Mar 14, 2023
777ce35
fix test
jbrockmendel Mar 14, 2023
4e4f47b
None->lib.no_default
jbrockmendel Mar 15, 2023
284c953
Merge branch 'main' into depr-align
jbrockmendel Mar 15, 2023
84454f6
update tests
jbrockmendel Mar 15, 2023
d2cf6db
fix Series.align test
jbrockmendel Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
@jbrockmendel
jbrockmendel committed Mar 14, 2023
commit 777ce35b6fd6f592bf26e4e68fc7ee6e9da7135f
3 changes: 2 additions & 1 deletion pandas/tests/series/methods/test_align.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,8 @@ def test_align_with_dataframe_method(method):
"The 'method', 'limit', and 'fill_axis' keywords in Series.align "
"are deprecated"
)
with tm.assert_produces_warning(FutureWarning, match=msg):
warn = None if method is None else FutureWarning
with tm.assert_produces_warning(warn, match=msg):
result_ser, result_df = ser.align(df, method=method)
tm.assert_series_equal(result_ser, ser)
tm.assert_frame_equal(result_df, df)
Expand Down