Do not generate build artifacts under target for check#124
Merged
Conversation
ascjones
reviewed
Jan 6, 2021
Collaborator
There was a problem hiding this comment.
Rather than building into a tmp dir, did you consider running cargo check instead of cargo build when invoking cargo for wasm and metadata gen?
e.g. I just ran the raw command cargo check --target wasm32-unknown-unknown -Zbuild-std -Zbuild-std-features=panic_immediate_abort --no-default-features and it worked as expected.
Collaborator
Author
|
@ascjones Thanks for the comments, I applied all of them. Can you take another look please? |
ascjones
reviewed
Jan 22, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our documentation for
cargo contract check:I found that despite this comment we actually output to the
targetdir. This PR changes this behavior by makingcheckbuild into a tmp dir.