Add preferred default release profile settings#55
Merged
Conversation
Robbepop
reviewed
Jun 15, 2020
Contributor
Robbepop
left a comment
There was a problem hiding this comment.
All in all LGTM, some renamings wouldn't hurt though.
Also really nice feature!
src/workspace.rs
Outdated
Comment on lines
+516
to
+518
| /// False = no LTO | ||
| /// True = "Fat" LTO | ||
| Bool(bool), |
Contributor
There was a problem hiding this comment.
Would it be much worse to have FatLto, ThinLto and Off as variants? Kind of dislike the Bool here.
Collaborator
Author
There was a problem hiding this comment.
See what you think of the explicit variants
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rel #40, use-ink/ink#448
If any of the following
[profile.release]settings are missing, then they are added with the following preferred defaults:Any of the above that are manually specified are not overwritten. This allows manual control over e.g.
opt-levelwhere in some casesopt-level = 3might result in a smaller binary size.Template changes:
[profile.release]sectionUse(reverted: requires ink! 3 release)scale-infofrom crates.io instead oftype-metadata