Skip to content

Add output-json check for instantiate command #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SkymanOne merged 2 commits into from
Nov 23, 2022
Merged

Add output-json check for instantiate command #839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30e3235
add output-json check
Nov 22, 2022
c79f0c6
add CHANGELOG entry
Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased
- Fixed having non-JSON output after calling `instantiate` with `--output-json` - [#839](https://github.com/paritytech/cargo-contract/pull/839/files)
Copy link
Contributor

@HCastano HCastano Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SkymanOne small thing, can you remove the files slug and add this under a ### Fixed header?


## [2.0.0-beta] - 2022-11-22

This release supports the ink! [`v4.0.0-beta`](https://github.com/paritytech/ink/releases/tag/v4.0.0-beta) release.
Expand Down
4 changes: 3 additions & 1 deletion crates/cargo-contract/src/cmd/extrinsics/instantiate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,9 @@ impl Exec {
let instantiate_result = self.instantiate_dry_run(code).await?;
match instantiate_result.result {
Ok(_) => {
super::print_gas_required_success(instantiate_result.gas_required);
if !self.output_json {
super::print_gas_required_success(instantiate_result.gas_required);
}
// use user specified values where provided, otherwise use the estimates
let ref_time = self
.args
Expand Down