Fix wrong contract account id for instantiate
#965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 14, 2023
lean-apple
requested review from
HCastano,
SkymanOne and
cmichi
as code owners
Collaborator
|
Oha, I somehow thought we had merged a hotfix for this issue. @ascjones We should issue a patch release with this one and the template fix. @lean-apple Is the PR still WIP? If not change the title please. Please also update the first sentence in the description to "Closes $link_to_issue.". When we merged the PR GitHub will then automatically close the issue. |
lean-apple
changed the title
instantiateinstantiate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #777.
The last contract account id was used instead of the first one for the Instantiated Event.
A
find_lastmethod was added in the events_types of subxt to lighten the current code and for block_types, here.