Implement seal_code_hash and seal_own_code_hash#1205
Merged
Conversation
agryaznov
requested review from
HCastano,
Robbepop,
ascjones and
cmichi
as code owners
agryaznov
force-pushed
the
ag-code-hash
branch
2 times, most recently
from
891f434 to
6a85959
Compare
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Fri Apr 8 19:08:26 CEST 2022 |
Codecov Report
@@ Coverage Diff @@
## master #1205 +/- ##
===========================================
+ Coverage 61.69% 78.98% +17.28%
===========================================
Files 228 229 +1
Lines 8637 8667 +30
===========================================
+ Hits 5329 6846 +1517
+ Misses 3308 1821 -1487
Continue to review full report at Codecov.
|
cmichi
requested changes
Apr 4, 2022
crates/env/src/api.rs
Outdated
| }) | ||
| } | ||
|
|
||
| /// Retrieves the code hash of a contract living at specified account |
Collaborator
There was a problem hiding this comment.
Could you also add a section /// # Errors here?
| <EnvInstance as OnInstance>::on_instance(|instance| instance.code_hash::<E>(account)) | ||
| } | ||
|
|
||
| /// Retrieves the code hash of the currently executing contract. |
Collaborator
There was a problem hiding this comment.
Could you also add a section /// # Errors here?
Co-authored-by: Michael Müller <mich@elmueller.net>
cmichi
reviewed
Apr 7, 2022
cmichi
reviewed
Apr 7, 2022
cmichi
reviewed
Apr 7, 2022
cmichi
reviewed
Apr 7, 2022
cmichi
reviewed
Apr 7, 2022
Co-authored-by: Michael Müller <mich@elmueller.net>
Co-authored-by: Michael Müller <mich@elmueller.net>
cmichi
reviewed
Apr 8, 2022
cmichi
reviewed
Apr 8, 2022
Co-authored-by: Michael Müller <mich@elmueller.net>
This reverts commit 5591d95.
cmichi
approved these changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for substrate#10933.
Resolves #1204.