Bump Substrate and subxt dependencies#1549
Conversation
We also need to bump `subxt` to a version that uses the same versions of our Substrate deps.
Not sure why we're going through this hidden internal module
Codecov Report
@@ Coverage Diff @@
## master #1549 +/- ##
==========================================
+ Coverage 70.43% 70.44% +0.01%
==========================================
Files 207 207
Lines 6395 6395
==========================================
+ Hits 4504 4505 +1
+ Misses 1891 1890 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
| <C::ExtrinsicParams as ExtrinsicParams<C::Index, C::Hash>>::OtherParams: Default, | ||
|
|
||
| C::AccountId: serde::de::DeserializeOwned, | ||
| C::AccountId: scale::Codec, |
There was a problem hiding this comment.
I'm not sure why they removed the Parameter (which is Codec + Clone etc. constraint from type AccountId
There was a problem hiding this comment.
@jsdw I meant to ping you about this last week, but yeah this shouldn't have been removed imo. If it was it should've also been mentioned in the release notes - I only saw it while looking through the PR diff
There was a problem hiding this comment.
I spoke with @jsdw about this and the outcome was that all bounds which are not required within subxt itself are removed. And that if we want global bounds we should use our own local trait.
crates/e2e/src/xts.rs
Outdated
| struct RpcInstantiateRequest<C: subxt::Config, E: Environment> { | ||
| struct RpcInstantiateRequest<C: subxt::Config, E: Environment> | ||
| where | ||
| C::AccountId: scale::Codec, |
There was a problem hiding this comment.
I reckon this bound on the struct is not necessary
3 participants
Bumps
subxttov0.26.0. Also updates the Substrate dependencies to the matchingversions used by
subxt.