[E2E alternative backend]: Make tests generic over client #1867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmikolajczyk41
requested review from
SkymanOne,
ascjones and
cmichi
as code owners
SkymanOne
approved these changes
Aug 4, 2023
Contributor
SkymanOne
left a comment
SkymanOne
left a comment
There was a problem hiding this comment.
Please add a changelog entry and we are good to go
Contributor
Author
|
sure thing - new entry added! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR making all the e2e integration tests generic over backend trait.
Note: Since the testcase signature is partly abandoned, the generic bound
Client: E2EBackendis not necessary (even import is not needed). However, I left it anyway for transparency.Note: These testcases have to be generic, since
E2EBackendis not object safe trait (nor areChainBackendandContractsBackend).