Skip to content

Commit f8ff15e

Browse files
authored
Add MessagesPalletInstance for integrity tests (#2107)
1 parent 92ccef5 commit f8ff15e

File tree

5 files changed

+19
-11
lines changed

5 files changed

+19
-11
lines changed

bin/millau/runtime/src/rialto_messages.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ mod tests {
166166

167167
#[test]
168168
fn ensure_millau_message_lane_weights_are_correct() {
169-
check_message_lane_weights::<bp_millau::Millau, Runtime>(
169+
check_message_lane_weights::<bp_millau::Millau, Runtime, WithRialtoMessagesInstance>(
170170
bp_rialto::EXTRA_STORAGE_PROOF_SIZE,
171171
bp_millau::MAX_UNREWARDED_RELAYERS_IN_CONFIRMATION_TX,
172172
bp_millau::MAX_UNCONFIRMED_MESSAGES_IN_CONFIRMATION_TX,

bin/millau/runtime/src/rialto_parachain_messages.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ mod tests {
172172

173173
#[test]
174174
fn ensure_millau_message_lane_weights_are_correct() {
175-
check_message_lane_weights::<bp_millau::Millau, Runtime>(
175+
check_message_lane_weights::<bp_millau::Millau, Runtime, WithRialtoParachainMessagesInstance>(
176176
bp_rialto_parachain::EXTRA_STORAGE_PROOF_SIZE,
177177
bp_millau::MAX_UNREWARDED_RELAYERS_IN_CONFIRMATION_TX,
178178
bp_millau::MAX_UNCONFIRMED_MESSAGES_IN_CONFIRMATION_TX,

bin/rialto-parachain/runtime/src/millau_messages.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,11 @@ mod tests {
150150

151151
#[test]
152152
fn ensure_millau_message_lane_weights_are_correct() {
153-
check_message_lane_weights::<bp_rialto_parachain::RialtoParachain, Runtime>(
153+
check_message_lane_weights::<
154+
bp_rialto_parachain::RialtoParachain,
155+
Runtime,
156+
WithMillauMessagesInstance,
157+
>(
154158
bp_millau::EXTRA_STORAGE_PROOF_SIZE,
155159
bp_rialto_parachain::MAX_UNREWARDED_RELAYERS_IN_CONFIRMATION_TX,
156160
bp_rialto_parachain::MAX_UNCONFIRMED_MESSAGES_IN_CONFIRMATION_TX,

bin/rialto/runtime/src/millau_messages.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ mod tests {
150150

151151
#[test]
152152
fn ensure_millau_message_lane_weights_are_correct() {
153-
check_message_lane_weights::<bp_rialto::Rialto, Runtime>(
153+
check_message_lane_weights::<bp_rialto::Rialto, Runtime, WithMillauMessagesInstance>(
154154
bp_millau::EXTRA_STORAGE_PROOF_SIZE,
155155
bp_rialto::MAX_UNREWARDED_RELAYERS_IN_CONFIRMATION_TX,
156156
bp_rialto::MAX_UNCONFIRMED_MESSAGES_IN_CONFIRMATION_TX,

bin/runtime-common/src/integrity.rs

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,8 @@ where
292292
/// Check that the message lane weights are correct.
293293
pub fn check_message_lane_weights<
294294
C: Chain,
295-
T: frame_system::Config + pallet_bridge_messages::Config,
295+
T: frame_system::Config + pallet_bridge_messages::Config<MessagesPalletInstance>,
296+
MessagesPalletInstance: 'static,
296297
>(
297298
bridged_chain_extra_storage_proof_size: u32,
298299
this_chain_max_unrewarded_relayers: MessageNonce,
@@ -303,15 +304,15 @@ pub fn check_message_lane_weights<
303304
// in other words: pass true for all known production chains
304305
runtime_includes_refund_extension: bool,
305306
) {
306-
type Weights<T> = <T as pallet_bridge_messages::Config>::WeightInfo;
307+
type Weights<T, MI> = <T as pallet_bridge_messages::Config<MI>>::WeightInfo;
307308

308309
// check basic weight assumptions
309-
pallet_bridge_messages::ensure_weights_are_correct::<Weights<T>>();
310+
pallet_bridge_messages::ensure_weights_are_correct::<Weights<T, MessagesPalletInstance>>();
310311

311312
// check that weights allow us to receive messages
312313
let max_incoming_message_proof_size = bridged_chain_extra_storage_proof_size
313314
.saturating_add(messages::target::maximal_incoming_message_size(C::max_extrinsic_size()));
314-
pallet_bridge_messages::ensure_able_to_receive_message::<Weights<T>>(
315+
pallet_bridge_messages::ensure_able_to_receive_message::<Weights<T, MessagesPalletInstance>>(
315316
C::max_extrinsic_size(),
316317
C::max_extrinsic_weight(),
317318
max_incoming_message_proof_size,
@@ -321,7 +322,7 @@ pub fn check_message_lane_weights<
321322
// check that weights allow us to receive delivery confirmations
322323
let max_incoming_inbound_lane_data_proof_size =
323324
InboundLaneData::<()>::encoded_size_hint_u32(this_chain_max_unrewarded_relayers as _);
324-
pallet_bridge_messages::ensure_able_to_receive_confirmation::<Weights<T>>(
325+
pallet_bridge_messages::ensure_able_to_receive_confirmation::<Weights<T, MessagesPalletInstance>>(
325326
C::max_extrinsic_size(),
326327
C::max_extrinsic_weight(),
327328
max_incoming_inbound_lane_data_proof_size,
@@ -336,9 +337,12 @@ pub fn check_message_lane_weights<
336337
// ensures the extension will not refund weight when it doesn't need to (i.e. if pallet
337338
// weights do not account weights of refund extension).
338339
if runtime_includes_refund_extension {
339-
assert_ne!(Weights::<T>::receive_messages_proof_overhead_from_runtime(), Weight::zero());
340340
assert_ne!(
341-
Weights::<T>::receive_messages_delivery_proof_overhead_from_runtime(),
341+
Weights::<T, MessagesPalletInstance>::receive_messages_proof_overhead_from_runtime(),
342+
Weight::zero()
343+
);
344+
assert_ne!(
345+
Weights::<T, MessagesPalletInstance>::receive_messages_delivery_proof_overhead_from_runtime(),
342346
Weight::zero()
343347
);
344348
}

0 commit comments

Comments
 (0)