[AHM] Make stuff public and derive (#9384)

Make some stuff public and derive traits. Also removes one silently
truncating constructor from ParaId.

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Author: ggwpez

polkadot/parachain/src/primitives.rs

@@ -190,6 +190,7 @@ impl From<u32> for Id {
 	}
 }
 
+#[cfg(any(feature = "std", feature = "runtime-benchmarks"))]
 impl From<usize> for Id {
 	fn from(x: usize) -> Self {
 		// can't panic, so need to truncate

polkadot/runtime/common/src/claims/mod.rs

@@ -174,6 +174,12 @@ impl<'de> Deserialize<'de> for EthereumAddress {
 	}
 }
 
+impl AsRef<[u8]> for EthereumAddress {
+	fn as_ref(&self) -> &[u8] {
+		&self.0[..]
+	}
+}
+
 #[derive(Encode, Decode, DecodeWithMemTracking, Clone, TypeInfo, MaxEncodedLen)]
 pub struct EcdsaSignature(pub [u8; 65]);
 

polkadot/runtime/common/src/paras_registrar/mod.rs

@@ -38,7 +38,7 @@ use polkadot_runtime_parachains::{
 };
 
 use crate::traits::{OnSwap, Registrar};
-use codec::{Decode, Encode};
+use codec::{Decode, DecodeWithMemTracking, Encode, MaxEncodedLen};
 pub use pallet::*;
 use polkadot_runtime_parachains::paras::{OnNewHead, ParaKind};
 use scale_info::TypeInfo;
@@ -47,15 +47,26 @@ use sp_runtime::{
 	RuntimeDebug,
 };
 
-#[derive(Encode, Decode, Clone, PartialEq, Eq, Default, RuntimeDebug, TypeInfo)]
+#[derive(
+	Encode,
+	Decode,
+	Clone,
+	PartialEq,
+	Eq,
+	Default,
+	RuntimeDebug,
+	TypeInfo,
+	MaxEncodedLen,
+	DecodeWithMemTracking,
+)]
 pub struct ParaInfo<Account, Balance> {
 	/// The account that has placed a deposit for registering this para.
-	pub(crate) manager: Account,
+	pub manager: Account,
 	/// The amount reserved by the `manager` account for the registration.
-	deposit: Balance,
+	pub deposit: Balance,
 	/// Whether the para registration should be locked from being controlled by the manager.
 	/// None means the lock had not been explicitly set, and should be treated as false.
-	locked: Option<bool>,
+	pub locked: Option<bool>,
 }
 
 impl<Account, Balance> ParaInfo<Account, Balance> {

polkadot/runtime/parachains/src/inclusion/mod.rs

@@ -197,6 +197,11 @@ pub trait RewardValidators {
 	fn reward_bitfields(validators: impl IntoIterator<Item = ValidatorIndex>);
 }
 
+impl RewardValidators for () {
+	fn reward_backing(_: impl IntoIterator<Item = ValidatorIndex>) {}
+	fn reward_bitfields(_: impl IntoIterator<Item = ValidatorIndex>) {}
+}
+
 /// Reads the footprint of queues for a specific origin type.
 pub trait QueueFootprinter {
 	type Origin;

prdoc/pr_9384.prdoc

@@ -0,0 +1,32 @@
+title: '[AHM] Make stuff public and derive'
+doc:
+- audience: Runtime Dev
+  description: |
+    Preparation for Asset hub migration by making fields public and doing some tweaks.  
+    Also hide one silently truncating constructor from `ParaId``.
+
+crates:
+- name: pallet-delegated-staking
+  bump: minor
+- name: pallet-staking-async
+  bump: minor
+- name: polkadot-runtime-parachains
+  bump: minor
+- name: pallet-referenda
+  bump: minor
+- name: pallet-bounties
+  bump: major
+- name: polkadot-runtime-common
+  bump: major
+- name: polkadot-parachain-primitives
+  bump: major
+- name: pallet-bags-list
+  bump: minor
+- name: pallet-multisig
+  bump: minor
+- name: pallet-nomination-pools
+  bump: minor
+- name: pallet-preimage
+  bump: minor
+- name: pallet-scheduler
+  bump: major

substrate/frame/bags-list/src/lib.rs

@@ -136,7 +136,7 @@ use sp_runtime::TryRuntimeError;
 #[cfg(any(feature = "runtime-benchmarks", test))]
 mod benchmarks;
 
-mod list;
+pub mod list;
 pub mod migrations;
 #[cfg(any(test, feature = "fuzz"))]
 pub mod mock;

substrate/frame/bounties/src/lib.rs

@@ -140,13 +140,13 @@ type BlockNumberFor<T, I = ()> =
 )]
 pub struct Bounty<AccountId, Balance, BlockNumber> {
 	/// The account proposing it.
-	proposer: AccountId,
+	pub proposer: AccountId,
 	/// The (total) amount that should be paid if the bounty is rewarded.
-	value: Balance,
+	pub value: Balance,
 	/// The curator fee. Included in value.
-	fee: Balance,
+	pub fee: Balance,
 	/// The deposit of curator.
-	curator_deposit: Balance,
+	pub curator_deposit: Balance,
 	/// The amount held on deposit (reserved) for making this proposal.
 	bond: Balance,
 	/// The status of this bounty.

substrate/frame/delegated-staking/src/lib.rs

@@ -131,7 +131,7 @@ pub mod migration;
 mod mock;
 #[cfg(test)]
 mod tests;
-mod types;
+pub mod types;
 
 extern crate alloc;
 

substrate/frame/multisig/src/lib.rs

@@ -104,7 +104,18 @@ pub struct Timepoint<BlockNumber> {
 }
 
 /// An open multisig operation.
-#[derive(Clone, Eq, PartialEq, Encode, Decode, Default, RuntimeDebug, TypeInfo, MaxEncodedLen)]
+#[derive(
+	Clone,
+	Eq,
+	PartialEq,
+	Encode,
+	Decode,
+	Default,
+	RuntimeDebug,
+	TypeInfo,
+	MaxEncodedLen,
+	DecodeWithMemTracking,
+)]
 #[scale_info(skip_type_params(MaxApprovals))]
 pub struct Multisig<BlockNumber, Balance, AccountId, MaxApprovals>
 where

substrate/frame/nomination-pools/src/lib.rs

@@ -1357,6 +1357,7 @@ impl<T: Config> BondedPool<T> {
 	Encode,
 	Decode,
 	MaxEncodedLen,
+	DecodeWithMemTracking,
 	TypeInfo,
 	CloneNoBound,
 	PartialEqNoBound,
@@ -1526,6 +1527,7 @@ impl<T: Config> RewardPool<T> {
 	Encode,
 	Decode,
 	MaxEncodedLen,
+	DecodeWithMemTracking,
 	TypeInfo,
 	DefaultNoBound,
 	RuntimeDebugNoBound,
@@ -1578,6 +1580,7 @@ impl<T: Config> UnbondPool<T> {
 	Encode,
 	Decode,
 	MaxEncodedLen,
+	DecodeWithMemTracking,
 	TypeInfo,
 	DefaultNoBound,
 	RuntimeDebugNoBound,