test for withdrawing before migrating delegation

Author: Ank4n

substrate/frame/nomination-pools/src/lib.rs

@@ -2300,12 +2300,13 @@ pub mod pallet {
 				// order to ensure members can leave the pool and it can be destroyed.
 				.min(T::StakeAdapter::transferable_balance(&bonded_pool.bonded_account()));
 
+			// this can fail if the pool uses `DelegateStake` strategy and the member delegation
+			// is not claimed yet. See `Call::claim_delegation()`.
 			T::StakeAdapter::member_withdraw(
 				&member_account,
 				&bonded_pool.bonded_account(),
 				balance_to_unbond,
-			)
-			.defensive()?;
+			)?;
 
 			Self::deposit_event(Event::<T>::Withdrawn {
 				member: member_account.clone(),

substrate/frame/nomination-pools/test-delegate-stake/src/lib.rs

@@ -29,6 +29,8 @@ use pallet_staking::{
 	CurrentEra, Error as StakingError, Event as StakingEvent, Payee, RewardDestination,
 };
 
+use pallet_delegated_staking::Error as DelegatedStakingError;
+
 use sp_runtime::{bounded_btree_map, traits::Zero};
 
 #[test]
@@ -882,6 +884,9 @@ fn pool_migration_e2e() {
 		// progress to a future era where funds are unlocked
 		CurrentEra::<Runtime>::set(Some(10));
 
+		// withdraw fails before claiming delegation
+		assert_noop!(Pools::withdraw_unbonded(RuntimeOrigin::signed(20), 20, 10), DelegatedStakingError::<Runtime>::NotDelegator);
+
 		let pre_claim_balance_20 = Balances::total_balance(&20);
 		assert_eq!(Balances::total_balance_on_hold(&20), 0);