Ban bandersnatch git dependency (#8136)

Changes:
- **Ban bandersnatch crate git dep**
- **Updated Mermaid with patch
glueball/simple-mermaid#2
- **inherit workspace dep**
- **Ban mermaid git dep**
- **Script nits**

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Author: ggwpez

.github/scripts/check-workspace.py

@@ -63,7 +63,7 @@ def get_members(workspace_dir, exclude):
 def get_crates(workspace_dir, exclude_crates) -> dict:
 	crates = {}
 
-	for root, dirs, files in os.walk(workspace_dir):
+	for root, _dirs, files in os.walk(workspace_dir):
 		if "target" in root:
 			continue
 		for file in files:
@@ -125,7 +125,7 @@ def check_links(all_crates):
 	links = []
 	broken = []
 
-	for name, (path, manifest) in all_crates.items():
+	for name, (_path, manifest) in all_crates.items():
 		def check_deps(deps):
 			for dep in deps:
 				# Could be renamed:

.github/scripts/deny-git-deps.py

@@ -11,10 +11,8 @@
 
 from cargo_workspace import Workspace, DependencyLocation
 
-KNOWN_BAD_GIT_DEPS = {
-	'simple-mermaid': ['xcm-docs'],
-	# Fix in <https://github.com/paritytech/polkadot-sdk/issues/2922>
-	'bandersnatch_vrfs': ['sp-core'],
+# Some crates are allowed to have git dependencies until we fix them.
+ALLOWED_GIT_DEPS = {
 	'subwasmlib': ['polkadot-zombienet-sdk-tests'],
 }
 
@@ -26,7 +24,7 @@ def check_dep(dep, used_by):
 	if dep.location != DependencyLocation.GIT:
 		return
 
-	if used_by in KNOWN_BAD_GIT_DEPS.get(dep.name, []):
+	if used_by in ALLOWED_GIT_DEPS.get(dep.name, []):
 		print(f'🤨 Ignoring git dependency {dep.name} in {used_by}')
 	else:
 		errors.append(f'🚫 Found git dependency {dep.name} in {used_by}')

.github/scripts/generate-prdoc.py

@@ -14,7 +14,6 @@
 import os
 import re
 import sys
-import subprocess
 import toml
 import yaml
 import requests

Cargo.lock

@@ -1238,6 +1238,7 @@ sha1 = { version = "0.10.6" }
 sha2 = { version = "0.10.7", default-features = false }
 sha3 = { version = "0.10.0", default-features = false }
 shlex = { version = "1.3.0" }
+simple-mermaid = { version = "0.1.1" }
 slot-range-helper = { path = "polkadot/runtime/common/slot_range_helper", default-features = false }
 slotmap = { version = "1.0" }
 smallvec = { version = "1.11.0", default-features = false }

Cargo.toml

@@ -29,7 +29,7 @@ scale-info = { workspace = true }
 # How we build docs in rust-docs
 docify = { workspace = true }
 serde_json = { workspace = true }
-simple-mermaid = "0.1.1"
+simple-mermaid = { workspace = true }
 
 # Polkadot SDK deps, typically all should only be in scope such that we can link to their doc item.
 chain-spec-builder = { workspace = true, default-features = true }

docs/sdk/Cargo.toml

@@ -30,7 +30,7 @@ pallet-message-queue = { workspace = true, default-features = true }
 
 # For building docs
 docify = { workspace = true }
-simple-mermaid = { git = "https://github.com/kianenigma/simple-mermaid.git", branch = "main" }
+simple-mermaid = { workspace = true }
 
 [dev-dependencies]
 test-log = { workspace = true }

polkadot/xcm/docs/Cargo.toml

@@ -38,7 +38,7 @@ sp-trie = { workspace = true }
 sp-weights = { workspace = true }
 tracing = { workspace = true, features = ["log"], default-features = false }
 
-simple-mermaid = { version = "0.1.1", optional = true }
+simple-mermaid = { workspace = true, optional = true }
 tuplex = { version = "0.1.2", default-features = false }
 
 [dev-dependencies]