From 8d8473c4e6a4d947c27fd933028d93ffc39dedda Mon Sep 17 00:00:00 2001 From: Viki Val Date: Mon, 18 Dec 2023 16:03:25 +0100 Subject: [PATCH 1/2] :bug: Depositing PalletAttributeSet on incorrect nft --- substrate/frame/nfts/src/lib.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/substrate/frame/nfts/src/lib.rs b/substrate/frame/nfts/src/lib.rs index 92b27432ab215..84673f70b39bf 100644 --- a/substrate/frame/nfts/src/lib.rs +++ b/substrate/frame/nfts/src/lib.rs @@ -874,8 +874,8 @@ pub mod pallet { ), ); Self::deposit_event(Event::PalletAttributeSet { - collection, - item: Some(item), + collection: collection_id, + item: Some(owned_item), attribute: pallet_attribute, value: attribute_value, }); From 535d7e5abba3369527c006595e19c1f956039242 Mon Sep 17 00:00:00 2001 From: Jegor Sidorenko Date: Thu, 29 Feb 2024 15:10:29 +0200 Subject: [PATCH 2/2] Add test --- substrate/frame/nfts/src/tests.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/substrate/frame/nfts/src/tests.rs b/substrate/frame/nfts/src/tests.rs index 9e521537534fa..6bf9427f4e6cd 100644 --- a/substrate/frame/nfts/src/tests.rs +++ b/substrate/frame/nfts/src/tests.rs @@ -440,6 +440,12 @@ fn mint_should_work() { account(2), Some(MintWitness { owned_item: Some(43), ..Default::default() }) )); + assert!(events().contains(&Event::::PalletAttributeSet { + collection: 0, + item: Some(43), + attribute: PalletAttributes::<::CollectionId>::UsedToClaim(1), + value: Nfts::construct_attribute_value(vec![]).unwrap(), + })); // can't mint twice assert_noop!(