updated batch verificaiton tests

Author: jakehemmerle

primitives/io/src/lib.rs

@@ -1550,14 +1550,14 @@ mod tests {
 		let mut ext = BasicExternalities::default();
 		ext.register_extension(TaskExecutorExt::new(TaskExecutor::new()));
 		ext.execute_with(|| {
-			// invalid ed25519 signature
+			// identity ed25519 signature is valid
 			crypto::start_batch_verify();
 			crypto::ed25519_batch_verify(
 				&Default::default(),
 				&Vec::new(),
 				&Default::default(),
 			);
-			assert!(!crypto::finish_batch_verify());
+			assert!(crypto::finish_batch_verify());
 
 			// 2 valid ed25519 signatures
 			crypto::start_batch_verify();
@@ -1577,16 +1577,13 @@ mod tests {
 			// 1 valid, 1 invalid ed25519 signature
 			crypto::start_batch_verify();
 
-			let pair = ed25519::Pair::generate_with_phrase(None).0;
+			let pair1 = ed25519::Pair::generate_with_phrase(None).0;
+			let pair2 = ed25519::Pair::generate_with_phrase(None).0;
 			let msg = b"Important message";
-			let signature = pair.sign(msg);
-			crypto::ed25519_batch_verify(&signature, msg, &pair.public());
+			let signature = pair1.sign(msg);
 
-			crypto::ed25519_batch_verify(
-				&Default::default(),
-				&Vec::new(),
-				&Default::default(),
-			);
+			crypto::ed25519_batch_verify(&signature, msg, &pair1.public());
+			crypto::ed25519_batch_verify(&signature, msg, &pair2.public());
 
 			assert!(!crypto::finish_batch_verify());
 
@@ -1621,7 +1618,7 @@ mod tests {
 			crypto::sr25519_batch_verify(
 				&Default::default(),
 				&Vec::new(),
-				&Default::default(),
+				&Default::default()
 			);
 
 			assert!(!crypto::finish_batch_verify());