Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Commit 781454d

Browse files
authored
Don't print "Discovered new external" line for private IPs (#10055)
1 parent d1ec40b commit 781454d

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

client/network/src/discovery.rs

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -599,14 +599,16 @@ impl NetworkBehaviour for DiscoveryBehaviour {
599599
fn inject_new_external_addr(&mut self, addr: &Multiaddr) {
600600
let new_addr = addr.clone().with(Protocol::P2p(self.local_peer_id.into()));
601601

602-
// NOTE: we might re-discover the same address multiple times
603-
// in which case we just want to refrain from logging.
604-
if self.known_external_addresses.insert(new_addr.clone()) {
605-
info!(
606-
target: "sub-libp2p",
607-
"🔍 Discovered new external address for our node: {}",
608-
new_addr,
609-
);
602+
if self.can_add_to_dht(addr) {
603+
// NOTE: we might re-discover the same address multiple times
604+
// in which case we just want to refrain from logging.
605+
if self.known_external_addresses.insert(new_addr.clone()) {
606+
info!(
607+
target: "sub-libp2p",
608+
"🔍 Discovered new external address for our node: {}",
609+
new_addr,
610+
);
611+
}
610612
}
611613

612614
for k in self.kademlias.values_mut() {

0 commit comments

Comments
 (0)