Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Commit a6ff3d3

Browse files
Fix ignored error in benchmark tests (#8214)
* fix ignored error in benchmark tests * use normal format for str * explicit match Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
1 parent 28107d4 commit a6ff3d3

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

frame/benchmarking/src/lib.rs

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1169,9 +1169,16 @@ macro_rules! impl_benchmark_test_suite {
11691169
let mut anything_failed = false;
11701170
println!("failing benchmark tests:");
11711171
for benchmark_name in $bench_module::<$test>::benchmarks($extra) {
1172-
if let Err(err) = std::panic::catch_unwind(|| test_bench_by_name::<$test>(benchmark_name)) {
1173-
println!("{}: {:?}", String::from_utf8_lossy(benchmark_name), err);
1174-
anything_failed = true;
1172+
match std::panic::catch_unwind(|| test_bench_by_name::<$test>(benchmark_name)) {
1173+
Err(err) => {
1174+
println!("{}: {:?}", String::from_utf8_lossy(benchmark_name), err);
1175+
anything_failed = true;
1176+
},
1177+
Ok(Err(err)) => {
1178+
println!("{}: {}", String::from_utf8_lossy(benchmark_name), err);
1179+
anything_failed = true;
1180+
},
1181+
Ok(Ok(_)) => (),
11751182
}
11761183
}
11771184
assert!(!anything_failed);

0 commit comments

Comments
 (0)