From 8af437f6b99f01d8298cdb795a69093b75ed910c Mon Sep 17 00:00:00 2001 From: Liam Aharon Date: Thu, 20 Apr 2023 16:59:40 +0400 Subject: [PATCH 1/4] add withdrawreason note --- frame/balances/src/impl_currency.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/frame/balances/src/impl_currency.rs b/frame/balances/src/impl_currency.rs index 329ea289f966e..aa159f32cb19b 100644 --- a/frame/balances/src/impl_currency.rs +++ b/frame/balances/src/impl_currency.rs @@ -16,6 +16,7 @@ // limitations under the License. //! Implementations for the `Currency` family of traits. +//! Note that WithdrawReason is intentionally not used for anything in this implementation. use super::*; use frame_support::{ From c553cebfb61bede9d3407d23a1735a6d6b89335d Mon Sep 17 00:00:00 2001 From: Liam Aharon Date: Thu, 20 Apr 2023 17:01:43 +0400 Subject: [PATCH 2/4] improve comment --- frame/balances/src/impl_currency.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frame/balances/src/impl_currency.rs b/frame/balances/src/impl_currency.rs index aa159f32cb19b..3d0c933e4e7b8 100644 --- a/frame/balances/src/impl_currency.rs +++ b/frame/balances/src/impl_currency.rs @@ -16,7 +16,7 @@ // limitations under the License. //! Implementations for the `Currency` family of traits. -//! Note that WithdrawReason is intentionally not used for anything in this implementation. +//! Note that WithdrawReasons are intentionally not used for anything in this implementation. use super::*; use frame_support::{ From e9c63c6f7ff5fa2d95fba0a33d1ca35e661210d5 Mon Sep 17 00:00:00 2001 From: Liam Aharon Date: Fri, 21 Apr 2023 01:12:14 +1000 Subject: [PATCH 3/4] Update frame/balances/src/impl_currency.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> --- frame/balances/src/impl_currency.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frame/balances/src/impl_currency.rs b/frame/balances/src/impl_currency.rs index 3d0c933e4e7b8..70a554e9f08f1 100644 --- a/frame/balances/src/impl_currency.rs +++ b/frame/balances/src/impl_currency.rs @@ -16,7 +16,8 @@ // limitations under the License. //! Implementations for the `Currency` family of traits. -//! Note that WithdrawReasons are intentionally not used for anything in this implementation. +//! +//! Note that `WithdrawReasons` are intentionally not used for anything in this implementation and are expected to be removed in the near future, once migration to `fungible::*` traits is done. use super::*; use frame_support::{ From 9356bd9a70f579bbddf8dbd1f8d4c4a868f23c03 Mon Sep 17 00:00:00 2001 From: Liam Aharon Date: Fri, 21 Apr 2023 10:45:37 +0400 Subject: [PATCH 4/4] cargo fmt +nightly --- frame/balances/src/impl_currency.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/frame/balances/src/impl_currency.rs b/frame/balances/src/impl_currency.rs index 70a554e9f08f1..ff8cc71d6224a 100644 --- a/frame/balances/src/impl_currency.rs +++ b/frame/balances/src/impl_currency.rs @@ -16,8 +16,9 @@ // limitations under the License. //! Implementations for the `Currency` family of traits. -//! -//! Note that `WithdrawReasons` are intentionally not used for anything in this implementation and are expected to be removed in the near future, once migration to `fungible::*` traits is done. +//! +//! Note that `WithdrawReasons` are intentionally not used for anything in this implementation and +//! are expected to be removed in the near future, once migration to `fungible::*` traits is done. use super::*; use frame_support::{