Skip to content

Add flag to see storage diff if idemptotent check fails #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Add flag to see storage diff if idemptotent check fails #78

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6fa391d
Add flag to see storage diff if idemptotent check fails
tmpolaczyk Feb 20, 2024
947f9cf
Update core/src/commands/on_runtime_upgrade.rs
tmpolaczyk Feb 26, 2024
7169c50
fmt
liamaharon Feb 27, 2024
203a7a9
update cargo.lock
liamaharon Feb 27, 2024
239172f
bump version
liamaharon Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update core/src/commands/on_runtime_upgrade.rs 
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
  • Loading branch information
@tmpolaczyk @ggwpez
tmpolaczyk and ggwpez authored Feb 26, 2024
commit 947f9cf7bee2782f2866c3bf5b5bbe70cea37369
2 changes: 1 addition & 1 deletion core/src/commands/on_runtime_upgrade.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ where
log::info!("Changed storage keys:");
let changes_after =
collect_storage_changes_as_hex::<Block>(&overlayed_changes);
overlayed_changes.rollback_transaction().unwrap();
overlayed_changes.rollback_transaction().expect("Migrations must not rollback transactions that they did not open");
let changes_before =
collect_storage_changes_as_hex::<Block>(&overlayed_changes);

Expand Down